linux-kernel - Re: [PATCH stable 5.15 v2] net: bcmgenet: Fix EEE implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cccd64f5-9a78-4653-a804-29e082e93910@broadcom.com>
Date: Sun, 11 Feb 2024 17:49:50 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Sasha Levin <sashal@...nel.org>
Cc: stable@...r.kernel.org, Russell King <rmk+kernel@...linux.org.uk>,
 Jakub Kicinski <kuba@...nel.org>, Doug Berger <opendmb@...il.com>,
 Florian Fainelli <f.fainelli@...il.com>,
 "David S. Miller" <davem@...emloft.net>,
 "open list:BROADCOM GENET ETHERNET DRIVER"
 <bcm-kernel-feedback-list@...adcom.com>,
 "open list:BROADCOM GENET ETHERNET DRIVER" <netdev@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH stable 5.15 v2] net: bcmgenet: Fix EEE implementation

On 2/11/2024 8:36 AM, Sasha Levin wrote:
> On Thu, Feb 08, 2024 at 11:06:05AM -0800, Florian Fainelli wrote:
>> [ Upstream commit a9f31047baca57d47440c879cf259b86f900260c ]
>>
>> We had a number of short comings:
>>
>> - EEE must be re-evaluated whenever the state machine detects a link
>>  change as wight be switching from a link partner with EEE
>>  enabled/disabled
>>
>> - tx_lpi_enabled controls whether EEE should be enabled/disabled for the
>>  transmit path, which applies to the TBUF block
>>
>> - We do not need to forcibly enable EEE upon system resume, as the PHY
>>  state machine will trigger a link event that will do that, too
>>
>> Fixes: 6ef398ea60d9 ("net: bcmgenet: add EEE support")
>> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
>> Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
>> Link: 
>> https://lore.kernel.org/r/20230606214348.2408018-1-florian.fainelli@broadcom.com
>> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> 
> It doesn't look like this one applies to 5.15...
> 

Yes I based it off an incorrect branch that has additional changes 
queued up locally, v3 coming shortly, thanks!
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)