linux-kernel - RE: [PATCH] iwlwifi/uefi: remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW5PR11MB5810B584F7C1545941E8C3C9A3482@MW5PR11MB5810.namprd11.prod.outlook.com>
Date: Mon, 12 Feb 2024 11:31:57 +0000
From: "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@...el.com>
To: Max Kellermann <max.kellermann@...os.com>, "kvalo@...nel.org"
	<kvalo@...nel.org>, "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "ayala.barazani@...el.com"
	<ayala.barazani@...el.com>
Subject: RE: [PATCH] iwlwifi/uefi: remove CONFIG_ACPI check

> 
> I don't know how the driver works, and I do not know why the CONFIG_ACPI
> check was added in the first place by commit c593d2fae592a
> ("iwlwifi: support SAR GEO Offset Mapping override via BIOS"), but since it did
> not add the same #ifdef to uefi.c, my first guess is that this piece of code shall
> be used even if ACPI is disabled.
> 
> Signed-off-by: Max Kellermann <max.kellermann@...os.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/fw/uefi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/fw/uefi.h
> b/drivers/net/wireless/intel/iwlwifi/fw/uefi.h
> index 39053290bd59..8617fe8b65cd 100644
> --- a/drivers/net/wireless/intel/iwlwifi/fw/uefi.h
> +++ b/drivers/net/wireless/intel/iwlwifi/fw/uefi.h
> @@ -285,7 +285,7 @@ static inline int iwl_uefi_get_dsm(struct iwl_fw_runtime
> *fwrt,  }  #endif /* CONFIG_EFI */
> 
> -#if defined(CONFIG_EFI) && defined(CONFIG_ACPI)
> +#if defined(CONFIG_EFI)
>  void iwl_uefi_get_sgom_table(struct iwl_trans *trans, struct iwl_fw_runtime
> *fwrt);  int iwl_uefi_get_uats_table(struct iwl_trans *trans,
>  			    struct iwl_fw_runtime *fwrt);
> --

Hi Max,

Thanks for your fix!
I think that I'd prefer Arnd Bergmans fix, looks cleaner to me.

Thanks!

> 2.39.2