[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <60499829-a5fa-54e6-42e3-bd48f25a65dc@arm.com>
Date: Mon, 12 Feb 2024 12:02:55 +0000
From: James Clark <james.clark@....com>
To: Anshuman Khandual <anshuman.khandual@....com>,
linux-arm-kernel@...ts.infradead.org, suzuki.poulose@....com
Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>,
Sudeep Holla <sudeep.holla@....com>, Mike Leach <mike.leach@...aro.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>, linux-acpi@...r.kernel.org,
linux-kernel@...r.kernel.org, coresight@...ts.linaro.org,
linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH V4 00/11] coresight: Move remaining AMBA ACPI devices into
platform driver
On 23/01/2024 05:45, Anshuman Khandual wrote:
> This moves remaining AMBA ACPI devices into respective platform drivers for
> enabling ACPI based power management support. This series applies on kernel
> v6.8-rc1 release. This series has been built, and boot tested on a DT based
> coresight platform. Although this still requires some more testing on ACPI
> based coresight platforms.
>
> https://git.gitlab.arm.com/linux-arm/linux-anshuman.git (amba_other_acpi_migration_v4)
>
> Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>
> Cc: Sudeep Holla <sudeep.holla@....com>
> Cc: Suzuki K Poulose <suzuki.poulose@....com>
> Cc: Mike Leach <mike.leach@...aro.org>
> Cc: James Clark <james.clark@....com>
> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>
> Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>
> Cc: linux-acpi@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> Cc: coresight@...ts.linaro.org
> Cc: linux-stm32@...md-mailman.stormreply.com
>
Reviewed-by: James Clark <james.clark@....com>
> Changes in V4:
>
> - Fixed PM imbalance in etm4_probe() error path with pm_runtime_disable()
> - Restored back the pm_runtime_disable() on platform probe error paths
> in replicator, funnel, catu, tpiu, tmc and stm devices
> - Dropped dev_caps argument from __tmc_probe()
> - Changed xxxx_platform_remove() for platform_driver->remove_new() callback
>
> Changes in V3:
>
> https://lore.kernel.org/all/20231208053939.42901-1-anshuman.khandual@arm.com/
>
> - Split coresight_init_driver/remove_driver() helpers into a separate patch
> - Added 'drvdata->pclk' comments in replicator, funnel, tpiu, tmc, and stm devices
> - Updated funnel, and replicator drivers to use these new helpers
> - Check for drvdata instead of drvdata->pclk in suspend and resume paths in catu,
> tmc and debug devices
> - Added patch to extract device name from AMBA pid based table lookup for stm
> - Added patch to extract device properties from AMBA pid based table look for tmc
> - Dropped pm_runtime_put() from common __probe() functions
> - Handled pm_runtime_put() in AMBA driver in success path
> - Handled pm_runtime_put() in platform driver in both success and error paths
>
> Changes in V2:
>
> https://lore.kernel.org/all/20231201062053.1268492-1-anshuman.khandual@arm.com/
>
> - Dropped redundant devm_ioremap_resource() hunk from tmc_platform_probe()
> - Defined coresight_[init|remove]_driver() for both AMBA/platform drivers
> - Changed catu, tmc, tpiu, stm and debug coresight drivers to use the new
> helpers avoiding build issues arising from module_amba_driver(), and
> module_platform_driver() being on the same file
>
> Changes in V1:
>
> https://lore.kernel.org/all/20231027072943.3418997-1-anshuman.khandual@arm.com/
>
> - Replaced all IS_ERR() instances with IS_ERR_OR_NULL() as per Suzuki
>
> Changes in RFC:
>
> https://lore.kernel.org/all/20230921042040.1334641-1-anshuman.khandual@arm.com/
>
> Anshuman Khandual (11):
> coresight: etm4x: Fix unbalanced pm_runtime_enable()
> coresight: stm: Extract device name from AMBA pid based table lookup
> coresight: tmc: Extract device properties from AMBA pid based table lookup
> coresight: Add helpers registering/removing both AMBA and platform drivers
> coresight: replicator: Move ACPI support from AMBA driver to platform driver
> coresight: funnel: Move ACPI support from AMBA driver to platform driver
> coresight: catu: Move ACPI support from AMBA driver to platform driver
> coresight: tpiu: Move ACPI support from AMBA driver to platform driver
> coresight: tmc: Move ACPI support from AMBA driver to platform driver
> coresight: stm: Move ACPI support from AMBA driver to platform driver
> coresight: debug: Move ACPI support from AMBA driver to platform driver
>
> drivers/acpi/arm64/amba.c | 8 -
> drivers/hwtracing/coresight/coresight-catu.c | 142 +++++++++++++---
> drivers/hwtracing/coresight/coresight-catu.h | 1 +
> drivers/hwtracing/coresight/coresight-core.c | 29 ++++
> .../hwtracing/coresight/coresight-cpu-debug.c | 141 ++++++++++++++--
> .../coresight/coresight-etm4x-core.c | 3 +
> .../hwtracing/coresight/coresight-funnel.c | 86 +++++-----
> drivers/hwtracing/coresight/coresight-priv.h | 10 ++
> .../coresight/coresight-replicator.c | 81 ++++-----
> drivers/hwtracing/coresight/coresight-stm.c | 117 +++++++++++--
> .../hwtracing/coresight/coresight-tmc-core.c | 158 +++++++++++++++---
> drivers/hwtracing/coresight/coresight-tmc.h | 2 +
> drivers/hwtracing/coresight/coresight-tpiu.c | 102 +++++++++--
> include/linux/coresight.h | 7 +
> 14 files changed, 726 insertions(+), 161 deletions(-)
>
Powered by blists - more mailing lists