linux-kernel - Re: [PATCH] filelock: ignore 'lock' argument to for_each_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240212-packpapier-messstation-c5a0c081a0c7@brauner>
Date: Mon, 12 Feb 2024 13:07:02 +0100
From: Christian Brauner <brauner@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: NeilBrown <neilb@...e.de>, Jeff Layton <jlayton@...nel.org>, 
	Arnd Bergmann <arnd@...db.de>, Luca Vizzarro <Luca.Vizzarro@....com>, 
	Tom Talpey <tom@...pey.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] filelock: ignore 'lock' argument to for_each_file_lock()

On Mon, Feb 12, 2024 at 12:26:11PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When CONFIG_FILE_LOCKING is disabled, ceph causes a warning about
> a variable that is only used insode of the for_each_file_lock()
> loop:
> 
> fs/ceph/locks.c: In function 'ceph_count_locks':
> fs/ceph/locks.c:380:27: error: unused variable 'lock' [-Werror=unused-variable]
>   380 |         struct file_lock *lock;
> 
> Rather than working around this in ceph, change the macro definition
> to still contain a reference to the variable in order to shut up the
> warning.
> 
> Fixes: 75cabec0111b ("filelock: add some new helper functions")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Yup, seems good to me.