linux-kernel - Re: [PATCH net-next v6 00/11] net: dsa: realtek: variants to drivers, interfaces to a common module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 12 Feb 2024 09:45:19 -0300
From: Luiz Angelo Daros de Luca <luizluca@...il.com>
To: patchwork-bot+netdevbpf@...nel.org
Cc: linus.walleij@...aro.org, alsi@...g-olufsen.dk, andrew@...n.ch, 
	f.fainelli@...il.com, olteanv@...il.com, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	linux@...linux.org.uk, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	florian.fainelli@...adcom.com
Subject: Re: [PATCH net-next v6 00/11] net: dsa: realtek: variants to drivers,
 interfaces to a common module

> Hello:
>
> This series was applied to netdev/net-next.git (main)
> by David S. Miller <davem@...emloft.net>:
>
> On Fri, 09 Feb 2024 02:03:36 -0300 you wrote:
> > The current driver consists of two interface modules (SMI and MDIO) and
> > two family/variant modules (RTL8365MB and RTL8366RB). The SMI and MDIO
> > modules serve as the platform and MDIO drivers, respectively, calling
> > functions from the variant modules. In this setup, one interface module
> > can be loaded independently of the other, but both variants must be
> > loaded (if not disabled at build time) for any type of interface. This
> > approach doesn't scale well, especially with the addition of more switch
> > variants (e.g., RTL8366B), leading to loaded but unused modules.
> > Additionally, this also seems upside down, as the specific driver code
> > normally depends on the more generic functions and not the other way
> > around.
> >
> > [...]
>
> Here is the summary with links:
>   - [net-next,v6,01/11] net: dsa: realtek: drop cleanup from realtek_ops
>     https://git.kernel.org/netdev/net-next/c/33f4336cbd32
>   - [net-next,v6,02/11] net: dsa: realtek: introduce REALTEK_DSA namespace
>     https://git.kernel.org/netdev/net-next/c/ded3813b44fe
>   - [net-next,v6,03/11] net: dsa: realtek: convert variants into real drivers
>     https://git.kernel.org/netdev/net-next/c/bce254b839ab
>   - [net-next,v6,04/11] net: dsa: realtek: keep variant reference in realtek_priv
>     https://git.kernel.org/netdev/net-next/c/4667a1db2f55
>   - [net-next,v6,05/11] net: dsa: realtek: common rtl83xx module
>     https://git.kernel.org/netdev/net-next/c/8be040ecd94c
>   - [net-next,v6,06/11] net: dsa: realtek: merge rtl83xx and
 interface modules into realtek_dsa
>     https://git.kernel.org/netdev/net-next/c/98b75c1c149c
>   - [net-next,v6,07/11] net: dsa: realtek: get internal MDIO node by name
>     https://git.kernel.org/netdev/net-next/c/8685c98d45c5
>   - [net-next,v6,08/11] net: dsa: realtek: clean user_mii_bus setup
>     https://git.kernel.org/netdev/net-next/c/68c66d8d8a19
>   - [net-next,v6,09/11] net: dsa: realtek: migrate user_mii_bus setup to realtek_dsa
>     https://git.kernel.org/netdev/net-next/c/b4bd77971f3c
>   - [net-next,v6,10/11] net: dsa: realtek: use the same mii bus driver for both interfaces
>     https://git.kernel.org/netdev/net-next/c/bba140a566ed
>   - [net-next,v6,11/11] net: dsa: realtek: embed dsa_switch into realtek_priv
>     https://git.kernel.org/netdev/net-next/c/9fc469b2943d
>
> You are awesome, thank you!

Thank you all involved, especially Vladmir who invested quite some time on this.

Regards,

Luiz