linux-kernel - Re: [PATCH v3] regmap: kunit: Ensure that changed bytes are actually different

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7979c4a4-d33d-4379-974a-12391b3a0ed7@sirena.org.uk>
Date: Mon, 12 Feb 2024 14:01:30 +0000
From: Mark Brown <broonie@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] regmap: kunit: Ensure that changed bytes are actually
 different

On Sun, Feb 11, 2024 at 10:54:25AM -0800, Guenter Roeck wrote:
> On Sun, Feb 11, 2024 at 04:58:17PM +0000, Mark Brown wrote:

> > -	KUNIT_EXPECT_MEMNEQ(test, &hw_buf[6], val, sizeof(u16));
> > +	KUNIT_EXPECT_MEMNEQ(test, &hw_buf[2], &val[0], sizeof(val));

> I kept those two checks separate on purpose because a non-equal check
> will "succeed" if a single byte is different. That means the above check
> will "pass" if one of regmap_raw_write() or regmap_write() works but
> the other is broken.

Good point, I'll do an incremental change for that though since that's
more of a belt and braces thing for something that should be checked
elsewhere than a core part of the test here.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)