linux-kernel - Re: [PATCH] [media] Clean up errors in dib0090.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a67b0054-06a7-4730-8694-082dd1a77125@xs4all.nl>
Date: Mon, 12 Feb 2024 15:56:21 +0100
From: Hans Verkuil <hverkuil@...all.nl>
To: XueBing Chen <chenxb_99091@....com>, mchehab@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH] [media] Clean up errors in dib0090.h

Hi!

First of all, the proper subject prefix is "media:", and in this case I
would say: "media: dvb-frontends:".

On 11/01/2024 12:05, XueBing Chen wrote:
> Fix the following errors reported by checkpatch:
> 
> ERROR: "foo * bar" should be "foo *bar"

Secondly, the error says that it should be "foo *bar"...

> 
> Signed-off-by: XueBing Chen <chenxb_99091@....com>
> ---
>  drivers/media/dvb-frontends/dib0090.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-frontends/dib0090.h b/drivers/media/dvb-frontends/dib0090.h
> index e5cb311694d9..613b0eb8c436 100644
> --- a/drivers/media/dvb-frontends/dib0090.h
> +++ b/drivers/media/dvb-frontends/dib0090.h
> @@ -82,7 +82,7 @@ extern u16 dib0090_get_wbd_offset(struct dvb_frontend *fe);
>  extern int dib0090_gain_control(struct dvb_frontend *fe);
>  extern enum frontend_tune_state dib0090_get_tune_state(struct dvb_frontend *fe);
>  extern int dib0090_set_tune_state(struct dvb_frontend *fe, enum frontend_tune_state tune_state);
> -extern void dib0090_get_current_gain(struct dvb_frontend *fe, u16 * rf, u16 * bb, u16 * rf_gain_limit, u16 * rflt);
> +extern void dib0090_get_current_gain(struct dvb_frontend *fe, u16* rf, u16* bb, u16* rf_gain_limit, u16* rflt);

..so why do you write "foo* bar"???

Regards,

	Hans

>  extern void dib0090_set_dc_servo(struct dvb_frontend *fe, u8 DC_servo_cutoff);
>  extern int dib0090_set_switch(struct dvb_frontend *fe, u8 sw1, u8 sw2, u8 sw3);
>  extern int dib0090_set_vga(struct dvb_frontend *fe, u8 onoff);