linux-kernel - Re: [PATCH v4 2/2] net: phy: dp83826: support TX data voltage tuning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 12 Feb 2024 15:04:24 +0000
From: POPESCU Catalin <catalin.popescu@...ca-geosystems.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "afd@...com" <afd@...com>,
	"hkallweit1@...il.com" <hkallweit1@...il.com>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	GEO-CHHER-bsp-development <bsp-development.geo@...ca-geosystems.com>,
	"m.felsch@...gutronix.de" <m.felsch@...gutronix.de>
Subject: Re: [PATCH v4 2/2] net: phy: dp83826: support TX data voltage tuning

On 12.02.24 15:37, Andrew Lunn wrote:
> [Some people who received this message don't often get email from andrew@...n.ch. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On Mon, Feb 12, 2024 at 02:15:47PM +0000, POPESCU Catalin wrote:
>> I just figured out that I forgot to disable WOL in the callback config_init.
>> It looks the PHY driver should explicitly disable WOL feature at init,
>> and leave it to ethtool to be enabled.
>> I will provide a v5 ASAP to fix that.
> WoL is a bit murky. On x86, it can be the BIOS which configures WoL,
> behind the back of Linux. That is not something i would actually
> recommend, so disabling it at boot does make sense. But consider
> suspend and resume. If the PHY is used for WoL, the WoL settings
> should be kept through suspend/resume. So you need to be careful where
> you disable it, so its only disables on boot, not resume.
>
>      Andrew

I see. Then, I should not disable WOL in config_init, since this 
callback is also called on the resume path : 
mdio_bus_phy_resume->phy_init_hw->config_init.
However, this contrasts with the rest of the driver and my patch is not 
anymore about just adding support for tuning of TX voltage levels ...