linux-kernel - Re: [patch v5 13/19] x86/mm/numa: Use core domain size on AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240212155609.GXZco_mU_K3wtg70W6@fat_crate.local>
Date: Mon, 12 Feb 2024 16:56:09 +0100
From: Borislav Petkov <bp@...en8.de>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
	Tom Lendacky <thomas.lendacky@....com>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Huang Rui <ray.huang@....com>, Juergen Gross <jgross@...e.com>,
	Dimitri Sivanich <dimitri.sivanich@....com>,
	Sohil Mehta <sohil.mehta@...el.com>,
	K Prateek Nayak <kprateek.nayak@....com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Zhang Rui <rui.zhang@...el.com>,
	"Paul E. McKenney" <paulmck@...nel.org>,
	Feng Tang <feng.tang@...el.com>,
	Andy Shevchenko <andy@...radead.org>,
	Michael Kelley <mhklinux@...look.com>,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: Re: [patch v5 13/19] x86/mm/numa: Use core domain size on AMD

On Tue, Jan 23, 2024 at 01:53:50PM +0100, Thomas Gleixner wrote:
> @@ -158,26 +156,25 @@ int __init amd_numa_init(void)
>  		return -ENOENT;
>  
>  	/*
> -	 * We seem to have valid NUMA configuration.  Map apicids to nodes
> -	 * using the coreid bits from early_identify_cpu.
> +	 * We seem to have valid NUMA configuration. Map apicids to nodes
> +	 * using the size of the core domain in the APIC space.

Since you're touching the comments:

	/*
	 * Valid NUMA configuration detected. Map APICIDs to nodes...

>  	 */
> -	bits = boot_cpu_data.x86_coreid_bits;
> -	cores = 1 << bits;
> -	apicid_base = 0;
> +	cores = topology_get_domain_size(TOPO_CORE_DOMAIN);

num_cores ...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette