lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bf0d02d4-2c90-40a4-8018-bd96a01f2751@suse.de>
Date: Mon, 12 Feb 2024 08:13:40 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH RESEND] iosys-map: fix typos

Hi

Am 12.02.24 um 05:28 schrieb Randy Dunlap:
> Correct spellos/typos in comments.
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: dri-devel@...ts.freedesktop.org
> ---
>   include/linux/iosys-map.h |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -- a/include/linux/iosys-map.h b/include/linux/iosys-map.h
> --- a/include/linux/iosys-map.h
> +++ b/include/linux/iosys-map.h
> @@ -34,7 +34,7 @@
>    * the same driver for allocation, read and write operations.
>    *
>    * Open-coding access to :c:type:`struct iosys_map <iosys_map>` is considered
> - * bad style. Rather then accessing its fields directly, use one of the provided
> + * bad style. Rather than accessing its fields directly, use one of the provided
Ok.
>    * helper functions, or implement your own. For example, instances of
>    * :c:type:`struct iosys_map <iosys_map>` can be initialized statically with
>    * IOSYS_MAP_INIT_VADDR(), or at runtime with iosys_map_set_vaddr(). These
> @@ -85,7 +85,7 @@
>    *	if (iosys_map_is_equal(&sys_map, &io_map))
>    *		// always false
>    *
> - * A set up instance of struct iosys_map can be used to access or manipulate the
> + * A setup instance of struct iosys_map can be used to access or manipulate the
That's not a typo. This refers to "an instance that has been set up".

Best regards
Thomas

>    * buffer memory. Depending on the location of the memory, the provided helpers
>    * will pick the correct operations. Data can be copied into the memory with
>    * iosys_map_memcpy_to(). The address can be manipulated with iosys_map_incr().

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ