linux-kernel - Re: [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CZ3974AW5FT3.39WK876PU00AZ@gmail.com>
Date: Mon, 12 Feb 2024 17:50:19 +0100
From: "Thierry Reding" <thierry.reding@...il.com>
To: "Jon Hunter" <jonathanh@...dia.com>, "Svyatoslav Ryhel"
 <clamor95@...il.com>, "Rob Herring" <robh+dt@...nel.org>, "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@...aro.org>, "Conor Dooley"
 <conor+dt@...nel.org>, "Shubhi Garg" <shgarg@...dia.com>
Cc: <devicetree@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7

On Mon Feb 12, 2024 at 5:14 PM CET, Jon Hunter wrote:
>
> On 12/02/2024 07:18, Svyatoslav Ryhel wrote:
> > Correct codename of Tegra Note 7 is "tegratab", while model
> > name should be "NVIDIA Tegra Note 7". Fix this inconsistency.
> > 
> > Signed-off-by: Svyatoslav Ryhel <clamor95@...il.com>
> > ---
> >   arch/arm/boot/dts/nvidia/Makefile                            | 4 ++--
> >   .../{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts}       | 5 +++--
> >   2 files changed, 5 insertions(+), 4 deletions(-)
> >   rename arch/arm/boot/dts/nvidia/{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} (98%)
> > 
> > diff --git a/arch/arm/boot/dts/nvidia/Makefile b/arch/arm/boot/dts/nvidia/Makefile
> > index 7a422f150488..474f3fbbd99d 100644
> > --- a/arch/arm/boot/dts/nvidia/Makefile
> > +++ b/arch/arm/boot/dts/nvidia/Makefile
> > @@ -2,8 +2,8 @@
> >   dtb-$(CONFIG_ARCH_TEGRA_114_SOC) += \
> >   	tegra114-asus-tf701t.dtb \
> >   	tegra114-dalmore.dtb \
> > -	tegra114-roth.dtb \
> > -	tegra114-tn7.dtb
> > +	tegra114-nvidia-tegratab.dtb \
> > +	tegra114-roth.dtb
> >   dtb-$(CONFIG_ARCH_TEGRA_124_SOC) += \
> >   	tegra124-apalis-eval.dtb \
> >   	tegra124-apalis-v1.2-eval.dtb \
> > diff --git a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> > similarity index 98%
> > rename from arch/arm/boot/dts/nvidia/tegra114-tn7.dts
> > rename to arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> > index bfbdb345575a..30b2ed91be23 100644
> > --- a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts
> > +++ b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> > @@ -5,8 +5,9 @@
> >   #include "tegra114.dtsi"
> >   
> >   / {
> > -	model = "Tegra Note 7";
> > -	compatible = "nvidia,tn7", "nvidia,tegra114";
> > +	model = "NVIDIA Tegra Note 7";
> > +	compatible = "nvidia,tegratab", "nvidia,tegra114";
> > +	chassis-type = "tablet";
>
> No mention of adding the chassis-type in the commit message. Seems like 
> that should be a separate change.

Agreed. Along with Krzysztof's comments maybe this should just be a
single patch that updates the model property and adds the chassis-type.
We haven't used chassis-type before, but I see that the devicetree
specification has it marked as "optional-but-recommended", so maybe we
should make a pass over all files and add these as appropriate.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)