linux-kernel - Re: linux-next: build failure after merge of the amdgpu tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_M4sE4K9OCGVSDU=na_eQTV3YyifPHoERam_zJHM_nqpA@mail.gmail.com>
Date: Tue, 13 Feb 2024 09:00:44 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Alex Deucher <alexander.deucher@....com>, 
	Mario Limonciello <mario.limonciello@....com>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the amdgpu tree

Thanks.  I've squashed the fix in.

Alex

On Mon, Feb 12, 2024 at 11:00 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Hi all,
>
> After merging the amdgpu tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:42:
> drivers/gpu/drm/amd/amdgpu/amdgpu.h:1559:13: error: 'amdgpu_choose_low_power_state' defined but not used [-Werror=unused-function]
>  1559 | static void amdgpu_choose_low_power_state(struct amdgpu_device *adev) { }
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> (and many, many more)
>
> Caused by commit
>
>   c77536b15b7a ("drm/amd: Stop evicting resources on APUs in suspend")
>
> I have applied the following patch for today.
>
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Date: Tue, 13 Feb 2024 14:41:05 +1100
> Subject: [PATCH] fixup for "drm/amd: Stop evicting resources on APUs in suspend"
>
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 2a3f12bae823..2cf4fb3f7751 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -1556,7 +1556,7 @@ void amdgpu_choose_low_power_state(struct amdgpu_device *adev);
>  #else
>  static inline bool amdgpu_acpi_is_s0ix_active(struct amdgpu_device *adev) { return false; }
>  static inline bool amdgpu_acpi_is_s3_active(struct amdgpu_device *adev) { return false; }
> -static void amdgpu_choose_low_power_state(struct amdgpu_device *adev) { }
> +static inline void amdgpu_choose_low_power_state(struct amdgpu_device *adev) { }
>  #endif
>
>  #if defined(CONFIG_DRM_AMD_DC)
> --
> 2.43.0
>
> --
> Cheers,
> Stephen Rothwell