linux-kernel - Re: [PATCH V2] vdpa: skip suspend/resume ops if not DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7de12bb2-30ed-4bd1-a9de-2032bcfef686@oracle.com>
Date: Tue, 13 Feb 2024 10:06:07 -0500
From: Steven Sistare <steven.sistare@...cle.com>
To: Eugenio Perez Martin <eperezma@...hat.com>
Cc: virtualization@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>, Si-Wei Liu <si-wei.liu@...cle.com>,
        Stefano Garzarella <sgarzare@...hat.com>
Subject: Re: [PATCH V2] vdpa: skip suspend/resume ops if not DRIVER_OK

On 2/13/2024 9:58 AM, Eugenio Perez Martin wrote:
> On Tue, Feb 13, 2024 at 3:26 PM Steve Sistare <steven.sistare@...cle.com> wrote:
>>
>> If a vdpa device is not in state DRIVER_OK, then there is no driver state
>> to preserve, so no need to call the suspend and resume driver ops.
>>
>> Suggested-by: Eugenio Perez Martin <eperezma@...hat.com>"
>> Signed-off-by: Steve Sistare <steven.sistare@...cle.com>
> 
> Reviewed-by: Eugenio Pérez <eperezma@...hat.com>
> 
> Please include a changelog from previous versions for the next series.
> 
> Thanks!

Will do, thanks - steve

>> ---
>>  drivers/vhost/vdpa.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
>> index bc4a51e4638b..aef92a7c57f3 100644
>> --- a/drivers/vhost/vdpa.c
>> +++ b/drivers/vhost/vdpa.c
>> @@ -595,6 +595,9 @@ static long vhost_vdpa_suspend(struct vhost_vdpa *v)
>>         const struct vdpa_config_ops *ops = vdpa->config;
>>         int ret;
>>
>> +       if (!(ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK))
>> +               return 0;
>> +
>>         if (!ops->suspend)
>>                 return -EOPNOTSUPP;
>>
>> @@ -615,6 +618,9 @@ static long vhost_vdpa_resume(struct vhost_vdpa *v)
>>         const struct vdpa_config_ops *ops = vdpa->config;
>>         int ret;
>>
>> +       if (!(ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK))
>> +               return 0;
>> +
>>         if (!ops->resume)
>>                 return -EOPNOTSUPP;
>>
>> --
>> 2.39.3
>>
>