linux-kernel - Re: [PATCH] dmaengine: idxd: make dsa_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 13 Feb 2024 09:15:44 -0800
From: Fenghua Yu <fenghua.yu@...el.com>
To: "Ricardo B. Marliere" <ricardo@...liere.net>, Dave Jiang
	<dave.jiang@...el.com>, Vinod Koul <vkoul@...nel.org>
CC: <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] dmaengine: idxd: make dsa_bus_type const



On 2/13/24 06:43, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct
> bus_type a const *"), the driver core can properly handle constant
> struct bus_type, move the dsa_bus_type variable to be a constant

nit: s/, move/. Change/

> structure as well, placing it into read-only memory which can not be
> modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@...liere.net>

Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>

> ---
>   drivers/dma/idxd/bus.c  | 2 +-
>   drivers/dma/idxd/idxd.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/bus.c b/drivers/dma/idxd/bus.c
> index 0c9e689a2e77..b83b27e04f2a 100644
> --- a/drivers/dma/idxd/bus.c
> +++ b/drivers/dma/idxd/bus.c
> @@ -72,7 +72,7 @@ static int idxd_bus_uevent(const struct device *dev, struct kobj_uevent_env *env
>   	return add_uevent_var(env, "MODALIAS=" IDXD_DEVICES_MODALIAS_FMT, 0);
>   }
>   
> -struct bus_type dsa_bus_type = {
> +const struct bus_type dsa_bus_type = {
>   	.name = "dsa",
>   	.match = idxd_config_bus_match,
>   	.probe = idxd_config_bus_probe,
> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> index 47de3f93ff1e..f14a660a2a34 100644
> --- a/drivers/dma/idxd/idxd.h
> +++ b/drivers/dma/idxd/idxd.h
> @@ -516,7 +516,7 @@ static inline void idxd_set_user_intr(struct idxd_device *idxd, bool enable)
>   	iowrite32(reg.bits, idxd->reg_base + IDXD_GENCFG_OFFSET);
>   }
>   
> -extern struct bus_type dsa_bus_type;
> +extern const struct bus_type dsa_bus_type;
>   
>   extern bool support_enqcmd;
>   extern struct ida idxd_ida;
> 
> ---
> base-commit: de7d9cb3b064fdfb2e0e7706d14ffee20b762ad2
> change-id: 20240213-bus_cleanup-idxd-8feaf2af5461
> 
> Best regards,

Thanks.

-Fenghua