linux-kernel - Re: [PATCH] nvmem: include bit index in cell sysfs file name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240213202045.1e823a6c@xps-13>
Date: Tue, 13 Feb 2024 20:20:45 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Eric Curtin <ecurtin@...hat.com>
Cc: srinivas.kandagatla@...aro.org, gregkh@...uxfoundation.org,
 linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
 regressions@...ts.linux.dev, Rafał Miłecki
 <rafal@...ecki.pl>, Chen-Yu Tsai <wenst@...omium.org>,
 asahi@...ts.linux.dev, Sven Peter <sven@...npeter.dev>
Subject: Re: [PATCH] nvmem: include bit index in cell sysfs file name

Hi,

ecurtin@...hat.com wrote on Fri, 9 Feb 2024 16:49:22 +0000:

> On Fri, 9 Feb 2024 at 16:43, <srinivas.kandagatla@...aro.org> wrote:
> >
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > Creating sysfs files for all Cells caused a boot failure for linux-6.8-rc1 on
> > Apple M1, which (in downstream dts files) has multiple nvmem cells that use the
> > same byte address. This causes the device probe to fail with
> >
> > [    0.605336] sysfs: cannot create duplicate filename '/devices/platform/soc@...000000/2922bc000.efuse/apple_efuses_nvmem0/cells/efuse@...'
> > [    0.605347] CPU: 7 PID: 1 Comm: swapper/0 Tainted: G S                 6.8.0-rc1-arnd-5+ #133
> > [    0.605355] Hardware name: Apple Mac Studio (M1 Ultra, 2022) (DT)
> > [    0.605362] Call trace:
> > [    0.605365]  show_stack+0x18/0x2c
> > [    0.605374]  dump_stack_lvl+0x60/0x80
> > [    0.605383]  dump_stack+0x18/0x24
> > [    0.605388]  sysfs_warn_dup+0x64/0x80
> > [    0.605395]  sysfs_add_bin_file_mode_ns+0xb0/0xd4
> > [    0.605402]  internal_create_group+0x268/0x404
> > [    0.605409]  sysfs_create_groups+0x38/0x94
> > [    0.605415]  devm_device_add_groups+0x50/0x94
> > [    0.605572]  nvmem_populate_sysfs_cells+0x180/0x1b0
> > [    0.605682]  nvmem_register+0x38c/0x470
> > [    0.605789]  devm_nvmem_register+0x1c/0x6c
> > [    0.605895]  apple_efuses_probe+0xe4/0x120
> > [    0.606000]  platform_probe+0xa8/0xd0
> >
> > As far as I can tell, this is a problem for any device with multiple cells on
> > different bits of the same address. Avoid the issue by changing the file name
> > to include the first bit number.
> >
> > Fixes: 0331c611949f ("nvmem: core: Expose cells through sysfs")
> > Link: https://github.com/AsahiLinux/linux/blob/bd0a1a7d4/arch/arm64/boot/dts/apple/t600x-dieX.dtsi#L156
> > Cc: regressions@...ts.linux.dev
> > Cc: Miquel Raynal <miquel.raynal@...tlin.com>
> > Cc: Rafał Miłecki <rafal@...ecki.pl>
> > Cc: Chen-Yu Tsai <wenst@...omium.org>
> > Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: asahi@...ts.linux.dev
> > Cc: Sven Peter <sven@...npeter.dev>
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>  
> 

My R-by must have been lost, here it is again:

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>

Thanks,
Miquèl