linux-kernel - Re: [PATCH v3 2/5] dt-bindings: fpga: xlnx,fpga-slave-serial: rename gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 13 Feb 2024 16:40:12 -0500 (EST)
From: Charles Perry <charles.perry@...oirfairelinux.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: mdf <mdf@...nel.org>, Allen VANDIVER <avandiver@...kem-imaje.com>, 
	Brian CODY <bcody@...kem-imaje.com>, hao wu <hao.wu@...el.com>, 
	yilun xu <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>, 
	Rob Herring <robh+dt@...nel.org>, 
	krzysztof kozlowski+dt <krzysztof.kozlowski+dt@...aro.org>, 
	Conor Dooley <conor+dt@...nel.org>, 
	Michal Simek <michal.simek@....com>, 
	kishore Manne <nava.kishore.manne@....com>, 
	linux-fpga <linux-fpga@...r.kernel.org>, 
	devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 2/5] dt-bindings: fpga: xlnx,fpga-slave-serial:
 rename gpios

On Feb 11, 2024, at 10:39 AM, Krzysztof Kozlowski krzysztof.kozlowski@...aro.org wrote:
> On 07/02/2024 19:01, Charles Perry wrote:
>> By convention, gpio consumer names should not contain underscores
>> (prog_b here) and shouldn't contain active low suffixes (-b here).
>> 
>> Signed-off-by: Charles Perry <charles.perry@...oirfairelinux.com>
>> ---
>>  .../bindings/fpga/xlnx,fpga-slave-serial.yaml        | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
>> b/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
>> index 614d86ad825f3..650a4d8792b64 100644
>> --- a/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
>> +++ b/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
>> @@ -36,7 +36,7 @@ properties:
>>    reg:
>>      maxItems: 1
>>  
>> -  prog_b-gpios:
>> +  prog-gpios:
> 
> Please deprecate old property and add allOf excluding the usage of both.
> Driver still parses old property, so we should have it documented.
> 
> https://lore.kernel.org/all/20230118163208.GA117919-robh@kernel.org/
> 
> Best regards,
> Krzysztof

Ok. Thank you for the example.

Regards,
Charles