[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e1eaefe0-6a22-48b5-9429-13f71cc0e6fb@lunn.ch>
Date: Tue, 13 Feb 2024 02:29:37 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, afd@...com, hkallweit1@...il.com,
linux@...linux.org.uk, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
bsp-development.geo@...ca-geosystems.com, m.felsch@...gutronix.de
Subject: Re: [PATCH v4 2/2] net: phy: dp83826: support TX data voltage tuning
On Mon, Feb 12, 2024 at 08:46:49AM +0100, Catalin Popescu wrote:
> DP83826 offers the possibility to tune the voltage of logical
> levels of the MLT-3 encoded TX data. This is useful when there
> is a voltage drop in between the PHY and the connector and we
> want to increase the voltage levels to compensate for that drop.
>
> Prior to PHY configuration, the driver SW resets the PHY which has
> the same effect as the HW reset pin according to the datasheet.
> Hence, there's no need to force update the VOD_CFG registers to make
> sure they hold their reset values. VOD_CFG registers need to be
> updated only if the DT has been configured with values other than
> the reset ones.
>
> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
Reviewed-by: Andrew Lunn <andrew@...n.ch>
FYI: The WoL discussion should not prevent this from being merged.
Andrew
Powered by blists - more mailing lists