lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9ad7967f-0a6a-96ed-1433-832f76752059@quicinc.com>
Date: Tue, 13 Feb 2024 11:24:30 +0530
From: Mukesh Ojha <quic_mojha@...cinc.com>
To: Subbaraman Narayanamurthy <quic_subbaram@...cinc.com>,
        <quic_mkshah@...cinc.com>
CC: <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_collinsd@...cinc.com>, <quic_eberman@...cinc.com>,
        <quic_lsrao@...cinc.com>, <stable@...r.kernel.org>
Subject: Re: [PATCH v3] soc: qcom: rpmh-rsc: Enhance check for VRM in-flight
 request



On 2/13/2024 9:22 AM, Subbaraman Narayanamurthy wrote:
> Hi Maulik,
> 
>> +bool cmd_db_match_resource_addr(u32 addr1, u32 addr2)
>> +{
> 
> <snip>
> 
>> +	if (SLAVE_ID(addr1) == CMD_DB_HW_VRM
>> +	    && VRM_ADDR(addr1) == VRM_ADDR(addr2))
>> +		return true;
>> +	else if (addr1 == addr2)
>> +		return true;
>> +	else
>> +		return false;
> 
> Minor..it would be better if you modify it as following.
> 
> +	if (addr1 == addr2)
> +		return true;
> +	else if (SLAVE_ID(addr1) == CMD_DB_HW_VRM
> +	    && VRM_ADDR(addr1) == VRM_ADDR(addr2))
> +		return true;
> +
> +	return false;

Even better if it becomes one statement for true rest with
false..
> 
> -Subbaraman
> 
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project.

Probably, you don't want to include this in your reply.

-Mukesh

> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ