linux-kernel - Re: [PATCH v2] extcon: max8997: select IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <56d3622f-4188-47e9-86ec-6870aa93a9d9@app.fastmail.com>
Date: Tue, 13 Feb 2024 09:26:24 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Randy Dunlap" <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: "MyungJoo Ham" <myungjoo.ham@...sung.com>,
 "Chanwoo Choi" <cw00.choi@...sung.com>, "Marc Zyngier" <maz@...nel.org>,
 "Philipp Zabel" <p.zabel@...gutronix.de>, "Peter Rosin" <peda@...ntia.se>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of depending on it

On Tue, Feb 13, 2024, at 07:00, Randy Dunlap wrote:
> IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set
> it directly thru "make *config", so drivers should select it instead
> of depending on it if they need it.
> Relying on it being set for a dependency is risky.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change EXTCON_MAX8997's use of "depends on" for
> IRQ_DOMAIN to "select".
>
> Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Arnd Bergmann <arnd@...db.de>

Acked-by: Arnd Bergmann <arnd@...db.de>