linux-kernel - Re: [PATCH 2/2] pinctrl: qcom: sm8450: Add pll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72ab2968-5e35-41c1-a689-6353a1d43b82@linaro.org>
Date: Tue, 13 Feb 2024 09:31:49 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Danila Tikhonov <danila@...xyga.com>, andersson@...nel.org,
 konrad.dybcio@...aro.org, linus.walleij@...aro.org, robh@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, vkoul@...nel.org
Cc: linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: qcom: sm8450: Add pll_clk to pin group 98
 for SM8475

On 12/02/2024 20:10, Danila Tikhonov wrote:
> Add pll_clk to pin group 98 for compatibility with SM8475.

I don't understand this. What compatibility? Is it valid on SM8450? Ifi
so, then this would be fix. If not, then you just introduced incorrect
group for SM8450 and called it compatibility.

> 
> Signed-off-by: Danila Tikhonov <danila@...xyga.com>
> ---
>  drivers/pinctrl/qcom/pinctrl-sm8450.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8450.c b/drivers/pinctrl/qcom/pinctrl-sm8450.c
> index 617286711695..45ac8e72c1c7 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm8450.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8450.c
> @@ -957,7 +957,7 @@ static const char * const pll_bist_groups[] = {
>  };
>  
>  static const char * const pll_clk_groups[] = {
> -	"gpio107",
> +	"gpio98", "gpio107",


Best regards,
Krzysztof