linux-kernel - Re: [PATCH v7 08/10] coresight-tpdm: Add timestamp control register support for the CMB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 13 Feb 2024 10:50:35 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Tao Zhang" <quic_taozha@...cinc.com>,
 "Mathieu Poirier" <mathieu.poirier@...aro.org>,
 "Suzuki K Poulose" <suzuki.poulose@....com>,
 "Alexander Shishkin" <alexander.shishkin@...ux.intel.com>,
 "Konrad Dybcio" <konradybcio@...il.com>,
 "Mike Leach" <mike.leach@...aro.org>, "Rob Herring" <robh+dt@...nel.org>,
 "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
 regressions@...ts.linux.dev
Cc: "Mao Jinlong" <quic_jinlmao@...cinc.com>, "Leo Yan" <leo.yan@...aro.org>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 "Tingwei Zhang" <quic_tingweiz@...cinc.com>,
 "Yuanfang Zhang" <quic_yuanfang@...cinc.com>,
 "Trilok Soni" <quic_tsoni@...cinc.com>,
 "Song Chai" <quic_songchai@...cinc.com>, linux-arm-msm@...r.kernel.org,
 "Bjorn Andersson" <andersson@...nel.org>
Subject: Re: [PATCH v7 08/10] coresight-tpdm: Add timestamp control register support
 for the CMB

On Sun, Feb 4, 2024, at 06:30, Tao Zhang wrote:

> @@ -910,7 +1014,7 @@ static struct attribute *tpdm_dsb_patt_attrs[] = {
>  	DSB_PATT_MASK_ATTR(5),
>  	DSB_PATT_MASK_ATTR(6),
>  	DSB_PATT_MASK_ATTR(7),
> -	&dev_attr_enable_ts.attr,
> +	DSB_PATT_ENABLE_TS,
>  	&dev_attr_set_type.attr,
>  	NULL,
>  };
> @@ -964,6 +1068,7 @@ static struct attribute *tpdm_cmb_patt_attrs[] = {
>  	CMB_PATT_ATTR(1),
>  	CMB_PATT_MASK_ATTR(0),
>  	CMB_PATT_MASK_ATTR(1),
> +	CMB_PATT_ENABLE_TS,
>  	NULL,
>  };
> 
> @@ -158,6 +175,10 @@
>  		tpdm_simple_dataset_rw(tpmr##nr,		\
>  		DSB_PATT_MASK, nr)
> 
> +#define DSB_PATT_ENABLE_TS					\
> +		tpdm_patt_enable_ts(enable_ts,			\
> +		DSB_PATT)
> +
>  #define DSB_MSR_ATTR(nr)					\
>  		tpdm_simple_dataset_rw(msr##nr,			\
>  		DSB_MSR, nr)

This is causing build failures in linux-next now:

drivers/hwtracing/coresight/coresight-tpdm.c:1055:2: error: missing field 'idx' initializer [-Werror,-Wmissing-field-initializers]
 1055 |         DSB_PATT_ENABLE_TS,
      |         ^
drivers/hwtracing/coresight/coresight-tpdm.h:184:3: note: expanded from macro 'DSB_PATT_ENABLE_TS'
  184 |                 tpdm_patt_enable_ts(enable_ts,                  \
      |                 ^
drivers/hwtracing/coresight/coresight-tpdm.h:156:5: note: expanded from macro 'tpdm_patt_enable_ts'
  156 |            }                                                    \
      |            ^
drivers/hwtracing/coresight/coresight-tpdm.c:1109:2: error: missing field 'idx' initializer [-Werror,-Wmissing-field-initializers]
 1109 |         CMB_PATT_ENABLE_TS,
      |         ^
drivers/hwtracing/coresight/coresight-tpdm.h:208:3: note: expanded from macro 'CMB_PATT_ENABLE_TS'
  208 |                 tpdm_patt_enable_ts(enable_ts,                  \
      |                 ^
drivers/hwtracing/coresight/coresight-tpdm.h:156:5: note: expanded from macro 'tpdm_patt_enable_ts'
  156 |            }                                                    \
      |            ^

Not sure what is going on, so I reverted your patch locally
for my test setup.
Can you send a fix to make it build again?

      Arnd