linux-kernel - Re: [PATCH v15 18/50] ASoC: Add SOC USB APIs for adding an USB backend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 13 Feb 2024 11:48:04 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Wesley Cheng <quic_wcheng@...cinc.com>
Cc: <srinivas.kandagatla@...aro.org>,
	<mathias.nyman@...el.com>,
	<perex@...ex.cz>,
	<conor+dt@...nel.org>,
	<corbet@....net>,
	<lgirdwood@...il.com>,
	<andersson@...nel.org>,
	<krzysztof.kozlowski+dt@...aro.org>,
	<gregkh@...uxfoundation.org>,
	<Thinh.Nguyen@...opsys.com>,
	<broonie@...nel.org>,
	<bgoswami@...cinc.com>,
	<tiwai@...e.com>,
	<robh+dt@...nel.org>,
	<konrad.dybcio@...aro.org>,
	<linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>,
	<linux-sound@...r.kernel.org>,
	<linux-usb@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>,
	<linux-doc@...r.kernel.org>,
	<alsa-devel@...a-project.org>
Subject: Re: [PATCH v15 18/50] ASoC: Add SOC USB APIs for adding an USB backend

On Tue, 13 Feb 2024 01:53:50 +0100,
Wesley Cheng wrote:
> 
> --- a/sound/soc/Kconfig
> +++ b/sound/soc/Kconfig
> @@ -76,6 +76,15 @@ config SND_SOC_UTILS_KUNIT_TEST
>  config SND_SOC_ACPI
>  	tristate
>  
> +config SND_SOC_USB
> +	bool "SoC based USB audio offloading"
> +	help
> +	  Enable this option if an ASoC platform card has support to handle
> +	  USB audio offloading.  This enables the SoC USB layer, which will
> +	  notifies the ASoC USB DPCM backend DAI link about available USB audio
> +	  devices.  Based on the notifications, sequences to enable the audio
> +	  stream can be taken based on the design.

This should be tristate, and...

> --- a/sound/soc/Makefile
> +++ b/sound/soc/Makefile
> @@ -31,6 +31,10 @@ endif
>  
>  obj-$(CONFIG_SND_SOC_ACPI) += snd-soc-acpi.o
>  
> +ifneq ($(CONFIG_SND_SOC_USB),)
> +snd-soc-core-objs += soc-usb.o
> +endif

.. split it to an individual module, i.e.:

snd-soc-usb-objs := soc-usb.o
obj-$(CONFIG_SND_SOC_USB) += snd-soc-usb.o

Otherwise it'll lead to a hard-dependency to snd-soc-core on
snd-usb-audio, which is utterly unnecessary for most of other
devices.


thanks,

Takashi