linux-kernel - [PATCH 2/7] EDAC/device: Remove edac_dev_sysfs_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 13 Feb 2024 12:20:46 +0100
From: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
To: bp@...en8.de
Cc: linux-kernel@...r.kernel.org,
	"Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
	Douglas Thompson <dougthompson@...ssion.com>,
	Tony Luck <tony.luck@...el.com>,
	James Morse <james.morse@....com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>,
	linux-edac@...r.kernel.org
Subject: [PATCH 2/7] EDAC/device: Remove edac_dev_sysfs_block_attribute::{block,value}

It's unused. And it never was since its addition in fd309a9d8e63e
(drivers/edac: fix leaf sysfs attribute). Drop it.

Found by https://github.com/jirislaby/clang-struct.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
Cc: Douglas Thompson <dougthompson@...ssion.com>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Tony Luck <tony.luck@...el.com>
Cc: James Morse <james.morse@....com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Robert Richter <rric@...nel.org>
Cc: linux-edac@...r.kernel.org
---
 drivers/edac/edac_device.c | 2 --
 drivers/edac/edac_device.h | 6 ------
 2 files changed, 8 deletions(-)

diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
index 0689e1510721..0e18729111d4 100644
--- a/drivers/edac/edac_device.c
+++ b/drivers/edac/edac_device.c
@@ -162,8 +162,6 @@ edac_device_alloc_ctl_info(unsigned pvt_sz, char *dev_name, unsigned nr_instance
 				attrib->show = attrib_spec[attr].show;
 				attrib->store = attrib_spec[attr].store;
 
-				attrib->block = blk;	/* up link */
-
 				edac_dbg(4, "alloc-attrib=%p attrib_name='%s' attrib-spec=%p spec-name=%s\n",
 					 attrib, attrib->attr.name,
 					 &attrib_spec[attr],
diff --git a/drivers/edac/edac_device.h b/drivers/edac/edac_device.h
index 7db22a4c83ef..c4704b5b1e9f 100644
--- a/drivers/edac/edac_device.h
+++ b/drivers/edac/edac_device.h
@@ -99,18 +99,12 @@ struct edac_dev_sysfs_attribute {
  *	can have an array of the following. The show and store functions
  *	will be filled in with the show/store function in the
  *	low level driver.
- *
- *	The 'value' field will be the actual value field used for
- *	counting
  */
 struct edac_dev_sysfs_block_attribute {
 	struct attribute attr;
 	ssize_t (*show)(struct kobject *, struct attribute *, char *);
 	ssize_t (*store)(struct kobject *, struct attribute *,
 			const char *, size_t);
-	struct edac_device_block *block;
-
-	unsigned int value;
 };
 
 /* device block control structure */
-- 
2.43.1