linux-kernel - Re: [PATCH v1] arm64: dts: ti: k3-am62-main: disable usb lpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 13 Feb 2024 13:34:12 +0200
From: Roger Quadros <rogerq@...nel.org>
To: Francesco Dolcini <francesco@...cini.it>
Cc: Andrejs Cainikovs <andrejs.cainikovs@...il.com>,
 Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
 Tero Kristo <kristo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Aswath Govindraju <a-govindraju@...com>,
 Sjoerd Simons <sjoerd@...labora.com>,
 Andrejs Cainikovs <andrejs.cainikovs@...adex.com>,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, "Bin Liu [EP]" <b-liu@...com>,
 "Gunasekaran, Ravi" <r-gunasekaran@...com>
Subject: Re: [PATCH v1] arm64: dts: ti: k3-am62-main: disable usb lpm



On 12/02/2024 14:54, Francesco Dolcini wrote:
> Hello Roger,
> 
> On Mon, Feb 12, 2024 at 02:13:56PM +0200, Roger Quadros wrote:
>> On 09/02/2024 15:02, Andrejs Cainikovs wrote:
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>>> index 464b7565d085..c49fbce5cb70 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>>> @@ -663,6 +665,8 @@ usb1: usb@...00000 {
>>>  			interrupt-names = "host", "peripheral";
>>>  			maximum-speed = "high-speed";
>>>  			dr_mode = "otg";
>>> +			snps,usb2-gadget-lpm-disable;
>>> +			snps,usb2-lpm-disable;
>>
>> Instead of this could you please check if this series fixes the issue for you?
>> https://lore.kernel.org/all/20240205141221.56076-1-rogerq@kernel.org/
> 
> Isn't this change correct despite whatever the test results on that
> change are going to be? The manual is pretty adamant on LPM not being
> supported by the AM62 SoC.
> 

You are right. We should have this in regardless.

-- 
cheers,
-roger