linux-kernel - Re: [PATCH v3 3/4] platform/mellanox: mlxbf-pmc: Add support for 64-bit counters and cycle count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c256234b-b928-23b7-d57b-464d5bfb3703@linux.intel.com>
Date: Tue, 13 Feb 2024 13:38:47 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Shravan Kumar Ramani <shravankr@...dia.com>
cc: Hans de Goede <hdegoede@...hat.com>, Vadim Pasternak <vadimp@...dia.com>, 
    David Thompson <davthompson@...dia.com>, 
    platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/4] platform/mellanox: mlxbf-pmc: Add support for
 64-bit counters and cycle count

Hi,

I've applied to first two type cleanup patches to review-ilpo.

I considered taking patch 3 and 4 already too but I'd like to see the 
sysfs documentation for the added sysfs files first.

On Tue, 13 Feb 2024, Shravan Kumar Ramani wrote:

> Add support for programming any counter to monitor the cycle count.
> Since counting of cycles using 32-bit ocunters would result in frequent

ocunters -> counters

> wraparounds, add the ability to combine 2 adjacent 32-bit counters to
> form 1 64-bit counter.
> Both these features are supported by BlueField-3 PMC hardware, hence

Please try to avoid paragraphs like this. Either make it a truly flowing 
paragraph or insert a newline in between the paragraphs.

> the required bit-fields are exposed by the driver via sysfs to allow
> the user to configure as needed.
> 
> Signed-off-by: Shravan Kumar Ramani <shravankr@...dia.com>
> Reviewed-by: David Thompson <davthompson@...dia.com>
> Reviewed-by: Vadim Pasternak <vadimp@...dia.com>

-- 
 i.