[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJZ5v0i0C3iPCUaUxfGGd+XjKmh7gY3G1e0uNG4mBm3FEmx8LA@mail.gmail.com>
Date: Tue, 13 Feb 2024 13:49:39 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: rafael@...nel.org, linux-kernel@...r.kernel.org,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, Len Brown <lenb@...nel.org>,
Viresh Kumar <viresh.kumar@...aro.org>, linux-pm@...r.kernel.org
Subject: Re: [PATCH] cpufreq/intel_pstate: remove cpudata::prev_cummulative_iowait
On Tue, Feb 13, 2024 at 12:16 PM Jiri Slaby (SUSE) <jirislaby@...nel.org> wrote:
>
> Commit 09c448d3c61f (cpufreq: intel_pstate: Use IOWAIT flag in Atom
> algorithm) removed the last user of cpudata::prev_cummulative_iowait. So
> remove the member too.
>
> Found by https://github.com/jirislaby/clang-struct.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: Len Brown <lenb@...nel.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: linux-pm@...r.kernel.org
> ---
> drivers/cpufreq/intel_pstate.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index ca94e60e705a..5ad3542c0e1e 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -201,8 +201,6 @@ struct global_params {
> * @prev_aperf: Last APERF value read from APERF MSR
> * @prev_mperf: Last MPERF value read from MPERF MSR
> * @prev_tsc: Last timestamp counter (TSC) value
> - * @prev_cummulative_iowait: IO Wait time difference from last and
> - * current sample
> * @sample: Storage for storing last Sample data
> * @min_perf_ratio: Minimum capacity in terms of PERF or HWP ratios
> * @max_perf_ratio: Maximum capacity in terms of PERF or HWP ratios
> @@ -241,7 +239,6 @@ struct cpudata {
> u64 prev_aperf;
> u64 prev_mperf;
> u64 prev_tsc;
> - u64 prev_cummulative_iowait;
> struct sample sample;
> int32_t min_perf_ratio;
> int32_t max_perf_ratio;
> --
Applied as 6.9 material, thanks!
Powered by blists - more mailing lists