linux-kernel - Re: [PATCH] platform/x86: think-lmi: Fix password opcode ordering for workstations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7aa1ac00-0db4-934a-94d5-b5daacaeb863@linux.intel.com>
Date: Tue, 13 Feb 2024 14:52:16 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>
cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
    Hans de Goede <hdegoede@...hat.com>, 
    "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: think-lmi: Fix password opcode ordering
 for workstations

On Fri, 9 Feb 2024, Mark Pearson wrote:

> Thanks Ilpo
> 
> On Fri, Feb 9, 2024, at 10:34 AM, Ilpo Järvinen wrote:
> > On Fri, 9 Feb 2024, Mark Pearson wrote:
> >
> >> The Lenovo workstations require the password opcode to be run before
> >> the attribute value is changed (if Admin password is enabled).
> >> 
> >> Tested on some Thinkpads to confirm they are OK with this order too.
> >> 
> >> Signed-off-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
> >
> > Would a Fixes tag be appropriate here?
> 
> Hmmm - good point, though it has been "wrong" since it was originally implemented (where we tested on Thinkpads).
> 
> I guess I could use the commit ID from when I originally implemented opcodes?
> Fixes: 640a5fa ("platform/x86: think-lmi: Opcode support")

Yes, in that case the original commit is the correct one.

> Do you want me to push a new version with this?

I think this is simple enough to go through fixes branch so it depends on 
Hans.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.