linux-kernel - Re: [PATCH 06/11] firmware: arm_scmi: Implement Clock .is_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zc0EqV69sg6Dqnti@pluto>
Date: Wed, 14 Feb 2024 18:21:29 +0000
From: Cristian Marussi <cristian.marussi@....com>
To: Nikunj Kela <quic_nkela@...cinc.com>
Cc: kernel test robot <lkp@...el.com>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, llvm@...ts.linux.dev,
	oe-kbuild-all@...ts.linux.dev, sudeep.holla@....com,
	vincent.guittot@...aro.org, peng.fan@....nxp.com,
	michal.simek@....com, quic_sibis@...cinc.com,
	souvik.chakravarty@....com
Subject: Re: [PATCH 06/11] firmware: arm_scmi: Implement Clock
 .is_notify_supported callback

On Tue, Feb 13, 2024 at 10:24:48AM -0800, Nikunj Kela wrote:
> 
> On 2/13/2024 12:49 AM, Cristian Marussi wrote:
> > On Tue, Feb 13, 2024 at 10:58:23AM +0800, kernel test robot wrote:
> > > Hi Cristian,
> > > 
> > > kernel test robot noticed the following build errors:
> > > 
> > > [auto build test ERROR on soc/for-next]
> > > [also build test ERROR on linus/master v6.8-rc4 next-20240212]
> > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > And when submitting patch, we suggest to use '--base' as documented in
> > > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > > 
> > Hi,
> > 
> > this series, as stated in the cover-letter, is based off the current tip of
> > 
> > 	sudeep/for-next/scmi/updates
> > 
> > and particularly needs commit:
> > 
> > 	9c5bc650031e firmware: arm_scmi: Rework clock domain info lookups
> > 
> > from there, since it contains the missing scmi_clock_domain_lookup().
> > 
> > Not_sure/dont_known if there is any way to convey this "based-on-branch"
> > info to your/any CI at the moment.
> > 
> > Thanks,
> > Cristian
> Maybe add supdeep's tree in MAINTAINERS and use 'base-commit'.

Thanks Nikunj, I'll try with base-commit.
Cristian

> > > url:    https://github.com/intel-lab-lkp/linux/commits/Cristian-Marussi/firmware-arm_scmi-Check-for-notification-support/20240212-203727
> > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
> > > patch link:    https://lore.kernel.org/r/20240212123233.1230090-7-cristian.marussi%40arm.com
> > > patch subject: [PATCH 06/11] firmware: arm_scmi: Implement Clock .is_notify_supported callback
> > > config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240213/202402131047.2NVZWHma-lkp@intel.com/config)
> > > compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project c08b90c50bcac9f3f563c79491c8dbcbe7c3b574)
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240213/202402131047.2NVZWHma-lkp@intel.com/reproduce)
> > > 
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@...el.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202402131047.2NVZWHma-lkp@intel.com/
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > > > > drivers/firmware/arm_scmi/clock.c:853:8: error: call to undeclared function 'scmi_clock_domain_lookup'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> > >       853 |         clk = scmi_clock_domain_lookup(ci, src_id);
> > >           |               ^
> > > > > drivers/firmware/arm_scmi/clock.c:853:6: error: incompatible integer to pointer conversion assigning to 'struct scmi_clock_info *' from 'int' [-Wint-conversion]
> > >       853 |         clk = scmi_clock_domain_lookup(ci, src_id);
> > >           |             ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >     2 errors generated.
> > > 
> > > 
> > > vim +/scmi_clock_domain_lookup +853 drivers/firmware/arm_scmi/clock.c
> > > 
> > >     842	
> > >     843	static bool scmi_clk_notify_supported(const struct scmi_protocol_handle *ph,
> > >     844					      u8 evt_id, u32 src_id)
> > >     845	{
> > >     846		bool supported;
> > >     847		struct scmi_clock_info *clk;
> > >     848		struct clock_info *ci = ph->get_priv(ph);
> > >     849	
> > >     850		if (evt_id >= ARRAY_SIZE(evt_2_cmd))
> > >     851			return false;
> > >     852	
> > >   > 853		clk = scmi_clock_domain_lookup(ci, src_id);
> > >     854		if (IS_ERR(clk))
> > >     855			return false;
> > >     856	
> > >     857		if (evt_id == SCMI_EVENT_CLOCK_RATE_CHANGED)
> > >     858			supported = clk->rate_changed_notifications;
> > >     859		else
> > >     860			supported = clk->rate_change_requested_notifications;
> > >     861	
> > >     862		return supported;
> > >     863	}
> > >     864	
> > > 
> > > -- 
> > > 0-DAY CI Kernel Test Service
> > > https://github.com/intel/lkp-tests/wiki