linux-kernel - Re: [PATCH 0/5] btrfs: use the super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240214185701.GB377066@zen.localdomain>
Date: Wed, 14 Feb 2024 10:57:01 -0800
From: Boris Burkov <boris@....io>
To: Johannes Thumshirn <johannes.thumshirn@....com>
Cc: Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
	David Sterba <dsterba@...e.com>, Christoph Hellwig <hch@....de>,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] btrfs: use the super_block as bdev holder

On Wed, Feb 14, 2024 at 08:42:11AM -0800, Johannes Thumshirn wrote:
> This is a series I've picked up from Christoph, it changes the
> block_device's bdev holder from fs_type to the super block.

Applies and builds on my for-next, and LGTM. A few non-urgent inline
comments in the patches, but assuming this has gone through CI again,

Reviewed-by: Boris Burkov <boris@....io>

> 
> Here's the original cover letter:
> Hi all,
> 
> this series contains the btrfs parts of the "remove get_super" from June
> that managed to get lost.
> 
> I've dropped all the reviews from back then as the rebase against the new
> mount API conversion led to a lot of non-trivial conflicts.
> 
> Josef kindly ran it through the CI farm and provided a fixup based on that.
> 
> ---
> Christoph Hellwig (5):
>       btrfs: always open the device read-only in btrfs_scan_one_device
>       btrfs: call btrfs_close_devices from ->kill_sb
>       btrfs: split btrfs_fs_devices.opened
>       btrfs: open block devices after superblock creation
>       btrfs: use the super_block as holder when mounting file systems
> 
>  fs/btrfs/disk-io.c |  4 +--
>  fs/btrfs/super.c   | 71 ++++++++++++++++++++++++++++++------------------------
>  fs/btrfs/volumes.c | 60 +++++++++++++++++++++++----------------------
>  fs/btrfs/volumes.h |  8 +++---
>  4 files changed, 78 insertions(+), 65 deletions(-)
> ---
> base-commit: a50d41606b333e4364844987deb1060e7ea6c038
> change-id: 20240214-hch-device-open-309ef9c98c62
> 
> Best regards,
> -- 
> Johannes Thumshirn <johannes.thumshirn@....com>
>