linux-kernel - Re: [PATCH] i2c: Remove redundant comparison in npcm_i2c_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 14 Feb 2024 23:25:23 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Avi Fishman <avifishman70@...il.com>, 
 Tomer Maimon <tmaimon77@...il.com>, Tali Perry <tali.perry1@...il.com>, 
 Patrick Venture <venture@...gle.com>, Nancy Yuen <yuenn@...gle.com>, 
 Benjamin Fair <benjaminfair@...gle.com>, openbmc@...ts.ozlabs.org, 
 linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Rand Deeb <rand.sec96@...il.com>
Cc: deeb.rand@...fident.ru, lvc-project@...uxtesting.org, 
 voskresenski.stanislav@...fident.ru
Subject: Re: [PATCH] i2c: Remove redundant comparison in npcm_i2c_reg_slave

Hi

On Tue, 06 Feb 2024 22:42:01 +0300, Rand Deeb wrote:
> In the npcm_i2c_reg_slave() function, there was a redundant
> comparison that checked if 'bus->slave' was null immediately after
> assigning it the 'client' value. There were concerns about a
> potential null dereference because of `client->adapter`, but
> according to Wolfram Sang, "we trusted ourselves here" Therefore,
> this comparison is unnecessary.
> 
> [...]

Applied to i2c/i2c-host on

git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git

Thank you,
Andi

Patches applied
===============
[1/1] i2c: Remove redundant comparison in npcm_i2c_reg_slave
      commit: 48acf8292280f257fb0047478153a81471ee7f4d