linux-kernel - Re: [PATCH v2] gen_compile_commands: fix invalid escape sequence warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFhGd8pvhzehMGh1XEHBct7CGEQuF0CZeneMH3D6cKSRj5UdHQ@mail.gmail.com>
Date: Tue, 13 Feb 2024 16:31:42 -0800
From: Justin Stitt <justinstitt@...gle.com>
To: Nicolas Schier <nicolas@...sle.eu>
Cc: Andrew Ballance <andrewjballance@...il.com>, masahiroy@...nel.org, 
	linux-kbuild@...r.kernel.org, linux-kernel-mentees@...ts.linuxfoundation.org, 
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, morbo@...gle.com, 
	nathan@...nel.org, ndesaulniers@...gle.com, skhan@...uxfoundation.org
Subject: Re: [PATCH v2] gen_compile_commands: fix invalid escape sequence warning

On Tue, Feb 13, 2024 at 12:00 PM Nicolas Schier <nicolas@...sle.eu> wrote:
>
> On Mon 12 Feb 2024 20:25:52 GMT, Andrew Ballance wrote:
> > with python 12.1 '\#' results in this warning
>
> funny typo: it's Python 3.12 :)

They probably meant Python 3.12.1 and forgot the "3." (or had a vim
moment resulting in its unfortunate removal)

>
> Kind regards,
> Nicolas
>
>
> >     SyntaxWarning: invalid escape sequence '\#'
> >
> > Signed-off-by: Andrew Ballance <andrewjballance@...il.com>
> > ---
> >  scripts/clang-tools/gen_compile_commands.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py
> > index 5dea4479240b..93f64095fda9 100755
> > --- a/scripts/clang-tools/gen_compile_commands.py
> > +++ b/scripts/clang-tools/gen_compile_commands.py
> > @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path):
> >      # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the
> >      # kernel version). The compile_commands.json file is not interepreted
> >      # by Make, so this code replaces the escaped version with '#'.
> > -    prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#')
> > +    prefix = command_prefix.replace('\\#', '#').replace('$(pound)', '#')
> >
> >      # Return the canonical path, eliminating any symbolic links encountered in the path.
> >      abs_path = os.path.realpath(os.path.join(root_directory, file_path))
> > --
> > 2.43.0
> >
>
> --
> Nicolas Schier
>
> epost|xmpp: nicolas@...sle.eu          irc://oftc.net/nsc
> ↳ gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
>      -- frykten for herren er opphav til kunnskap --