linux-kernel - Re: [PATCH] wifi: ath12k: sanitize ath12k_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <170790025305.3179441.138152315558305278.kvalo@kernel.org>
Date: Wed, 14 Feb 2024 08:44:14 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Jeff Johnson <quic_jjohnson@...cinc.com>,
 Karthikeyan Periyasamy <quic_periyasa@...cinc.com>,
 Arnd Bergmann <arnd@...db.de>, Aloka Dixit <quic_alokad@...cinc.com>,
 Wen Gong <quic_wgong@...cinc.com>, Muna Sinada <quic_msinada@...cinc.com>,
 Aditya Kumar Singh <quic_adisi@...cinc.com>, ath12k@...ts.infradead.org,
 linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: ath12k: sanitize ath12k_mac_allocate() return code

Arnd Bergmann <arnd@...nel.org> wrote:

> The return code has no initializer:
> 
> drivers/net/wireless/ath/ath12k/mac.c:8006:9: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
> 
> Make it return -ENOMEM for allocation failures and remove the unused
> variable instead.
> 
> Fixes: 6db6e70a17f6 ("wifi: ath12k: Introduce the container for mac80211 hw")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

Nathan already fixed this:

https://git.kernel.org/kvalo/ath/c/04edb5dc68f4

Patch set to Rejected.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240213100912.459018-1-arnd@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches