linux-kernel - Re: [PATCH v6 1/6] printk: Save console options for add_preferred_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 14 Feb 2024 10:51:38 +0200
From: Tony Lindgren <tony@...mide.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>, Petr Mladek <pmladek@...e.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	"David S . Miller" <davem@...emloft.net>,
	Dhruva Gole <d-gole@...com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Johan Hovold <johan@...nel.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Vignesh Raghavendra <vigneshr@...com>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH v6 1/6] printk: Save console options for
 add_preferred_console_match()

* Tony Lindgren <tony@...mide.com> [240214 10:49]:
> * Andy Shevchenko <andriy.shevchenko@...ux.intel.com> [240213 16:42]:
> > 		strscpy(con->name, str, namelen);
> > 		strscpy(con->opt, opt, optlen); // not sure if emptying opt is okay
> 
> The strings above now get terminated too sort with the + 1 removed,
> I suggest we use what we already do for brl_opt:
> 
> 		strscpy(con->name, str, CONSOLE_NAME_MAX);
> 		strscpy(con->opt, opt, CONSOLE_OPT_MAX);
> 

Heh but that won't work for str and CONSOLE_NAME_MAX..

Tony