linux-kernel - Re: [PATCH v2] of: OF_IRQ: select IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <867cj75q52.wl-maz@kernel.org>
Date: Wed, 14 Feb 2024 09:52:41 +0000
From: Marc Zyngier <maz@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Rob Herring <robh@...nel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Peter Rosin <peda@...ntia.se>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v2] of: OF_IRQ: select IRQ_DOMAIN instead of depending on it

On Tue, 13 Feb 2024 22:56:19 +0000,
Randy Dunlap <rdunlap@...radead.org> wrote:
> 
> IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set
> it directly thru "make *config", so drivers should select it instead
> of depending on it if they need it.
> Relying on it being set for a dependency is risky.
> 
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
> 
> Therefore, change OF_IRQ's use of "depends on" to "select".
> 
> This patch reduces one Kconfig circular dependency in
> drivers/mux/Kconfig when MUX_MMIO attempts to select REGMAP (a failed
> patch), which that driver needs (but does not completely resolve that
> issue). [1]
> 
> before this patch: (10 lines of detail)
> drivers/net/ethernet/arc/Kconfig:19:error: recursive dependency detected!
> drivers/net/ethernet/arc/Kconfig:19:	symbol ARC_EMAC_CORE is selected by ARC_EMAC
> drivers/net/ethernet/arc/Kconfig:26:	symbol ARC_EMAC depends on OF_IRQ
> drivers/of/Kconfig:81:	symbol OF_IRQ depends on IRQ_DOMAIN
> kernel/irq/Kconfig:60:	symbol IRQ_DOMAIN is selected by REGMAP
> drivers/base/regmap/Kconfig:6:	symbol REGMAP is selected by MUX_MMIO
> drivers/mux/Kconfig:48:	symbol MUX_MMIO depends on MULTIPLEXER
> drivers/mux/Kconfig:6:	symbol MULTIPLEXER is selected by MDIO_BUS_MUX_MULTIPLEXER
> drivers/net/mdio/Kconfig:275:	symbol MDIO_BUS_MUX_MULTIPLEXER depends on MDIO_DEVICE
> drivers/net/mdio/Kconfig:6:	symbol MDIO_DEVICE is selected by PHYLIB
> drivers/net/phy/Kconfig:16:	symbol PHYLIB is selected by ARC_EMAC_CORE
> 
> after this patch: (5 lines of detail)
> drivers/mux/Kconfig:6:error: recursive dependency detected!
> drivers/mux/Kconfig:6:	symbol MULTIPLEXER is selected by MDIO_BUS_MUX_MULTIPLEXER
> drivers/net/mdio/Kconfig:275:	symbol MDIO_BUS_MUX_MULTIPLEXER depends on MDIO_BUS
> drivers/net/mdio/Kconfig:13:	symbol MDIO_BUS is selected by REGMAP
> drivers/base/regmap/Kconfig:6:	symbol REGMAP is selected by MUX_MMIO
> drivers/mux/Kconfig:48:	symbol MUX_MMIO depends on MULTIPLEXER
> 
> [1] https://lore.kernel.org/lkml/20230210115625.GA30942@pengutronix.de/
> 
> Fixes: 63c60e3a6dc3 ("of: OF_IRQ should depend on IRQ_DOMAIN")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Rob Herring <robh@...nel.org>
> Cc: Marc Zyngier <maz@...nel.org>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Peter Rosin <peda@...ntia.se>
> Cc: devicetree@...r.kernel.org
> ---
> v2: update patch description, rebase & resend
> 
>  drivers/of/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff -- a/drivers/of/Kconfig b/drivers/of/Kconfig
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -80,7 +80,8 @@ config OF_ADDRESS
>  
>  config OF_IRQ
>  	def_bool y
> -	depends on !SPARC && IRQ_DOMAIN
> +	depends on !SPARC
> +	select IRQ_DOMAIN
>  
>  config OF_RESERVED_MEM
>  	def_bool OF_EARLY_FLATTREE
> 

This seems to be moving is the right direction. FWIW,

Acked-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.