[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <24cbf7b2-a091-440e-92cc-5c9828d52260@xs4all.nl>
Date: Wed, 14 Feb 2024 11:24:41 +0100
From: Hans Verkuil <hverkuil-cisco@...all.nl>
To: Arnd Bergmann <arnd@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Arnd Bergmann <arnd@...db.de>, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org, Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH] media: v4l: marvell: select CONFIG_V4L2_ASYNC where
needed
Arnd, Sakari,
Is this something that needs to go to v6.8? Or just v6.9?
Do we need a Fixes tag?
Regards,
Hans
On 13/02/2024 10:55, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> Drivers that call v4l2_async_nf_init() need to select the corresponding
> Kconfig symbol:
>
> ERROR: modpost: "v4l2_async_nf_init" [drivers/media/platform/marvell/cafe_ccic.ko] undefined!
> ERROR: modpost: "__v4l2_async_nf_add_i2c" [drivers/media/platform/marvell/cafe_ccic.ko] undefined!
> ERROR: modpost: "v4l2_async_nf_unregister" [drivers/media/platform/marvell/mcam-core.ko] undefined!
> ERROR: modpost: "v4l2_async_nf_init" [drivers/media/platform/marvell/mmp_camera.ko] undefined!
> ERROR: modpost: "__v4l2_async_nf_add_fwnode_remote" [drivers/media/platform/marvell/mmp_camera.ko] undefined!
>
> I checked all v4l2 drivers to see if anything else has the same
> bug, but these two appear to be the only ones.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> drivers/media/platform/marvell/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/marvell/Kconfig b/drivers/media/platform/marvell/Kconfig
> index d6499ffe30e8..d31f4730f2a3 100644
> --- a/drivers/media/platform/marvell/Kconfig
> +++ b/drivers/media/platform/marvell/Kconfig
> @@ -7,6 +7,7 @@ config VIDEO_CAFE_CCIC
> depends on V4L_PLATFORM_DRIVERS
> depends on PCI && I2C && VIDEO_DEV
> depends on COMMON_CLK
> + select V4L2_ASYNC
> select VIDEO_OV7670 if MEDIA_SUBDRV_AUTOSELECT && VIDEO_CAMERA_SENSOR
> select VIDEOBUF2_VMALLOC
> select VIDEOBUF2_DMA_CONTIG
> @@ -24,6 +25,7 @@ config VIDEO_MMP_CAMERA
> depends on COMMON_CLK
> select VIDEO_OV7670 if MEDIA_SUBDRV_AUTOSELECT && VIDEO_CAMERA_SENSOR
> select I2C_GPIO
> + select V4L2_ASYNC
> select VIDEOBUF2_VMALLOC
> select VIDEOBUF2_DMA_CONTIG
> select VIDEOBUF2_DMA_SG
Powered by blists - more mailing lists