linux-kernel - Re: [PATCH 06/11] s390/boot: vmlinux.lds.S: Handle '.rela' sections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 14 Feb 2024 13:17:55 +0100
From: Heiko Carstens <hca@...ux.ibm.com>
To: Fangrui Song <maskray@...gle.com>
Cc: Nathan Chancellor <nathan@...nel.org>, gor@...ux.ibm.com,
        agordeev@...ux.ibm.com, borntraeger@...ux.ibm.com, svens@...ux.ibm.com,
        ndesaulniers@...gle.com, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        patches@...ts.linux.dev
Subject: Re: [PATCH 06/11] s390/boot: vmlinux.lds.S: Handle '.rela' sections

On Mon, Feb 12, 2024 at 09:18:34PM -0800, Fangrui Song wrote:
> >         ASSERT(SIZEOF(.plt) == 0, "Unexpected run-time procedure linkages detected!")
> > +       .rela.dyn : {
> > +               *(.rela.*) *(.rela_*)
> > +       }
> > +       ASSERT(SIZEOF(.rela.dyn) == 0, "Unexpected run-time relocations (.rela) detected!")
..
> Commit 5354e84598f264793265cc99b4be2a2295826c86 ("x86/build: Add
> asserts for unwanted sections")
> specifies `*(.rela.*) *(.rela_*)` but it's not clear why `.rela_*` is
> included. We only need .rela.* (see also ld.bfd --verbose)
> 
> This patch LGTM with this changed.

I'll keep it as it is, just to be consistent with x86.