linux-kernel - Re: [PATCH] regulator: qcom-rpmh: Fix pm8010 pmic5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zcy+roPWLIVfjWs8@linaro.org>
Date: Wed, 14 Feb 2024 15:22:54 +0200
From: Abel Vesa <abel.vesa@...aro.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: bryan.odonoghue@...us-software.ie, andersson@...nel.org,
	konrad.dybcio@...aro.org, lgirdwood@...il.com, broonie@...nel.org,
	quic_fenglinw@...cinc.com, quic_collinsd@...cinc.com,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: qcom-rpmh: Fix pm8010 pmic5_pldo502ln minimum
 voltage

On 24-02-14 12:16:14, Bryan O'Donoghue wrote:
> The relevant documents and the dtsi specify the minimum value at 1.808v not
> 1.8v.
> 
> Prior to this fix we get the following error on boot:
> [    1.353540] vrej_l3m_1p8: failed to get the current voltage: -ENOTRECOVERABLE
> [    1.353544] qcom-rpmh-regulator 17500000.rsc:regulators-9: ldo3: devm_regulator_register() failed, ret=-131
> [    1.353546] qcom-rpmh-regulator: probe of 17500000.rsc:regulators-9 failed with error -131
> 
> Fixes: 2544631faa7f ("regulator: qcom-rpmh: add support for pm8010 regulators")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>

Reviewed-by: Abel Vesa <abel.vesa@...aro.org>

> ---
>  drivers/regulator/qcom-rpmh-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
> index 80e304711345b..767a17fe0d51b 100644
> --- a/drivers/regulator/qcom-rpmh-regulator.c
> +++ b/drivers/regulator/qcom-rpmh-regulator.c
> @@ -757,7 +757,7 @@ static const struct rpmh_vreg_hw_data pmic5_pldo502ln = {
>  	.regulator_type = VRM,
>  	.ops = &rpmh_regulator_vrm_ops,
>  	.voltage_ranges = (struct linear_range[]) {
> -		REGULATOR_LINEAR_RANGE(1800000, 0,  2,  200000),
> +		REGULATOR_LINEAR_RANGE(1808000, 0,  2,  200000),
>  		REGULATOR_LINEAR_RANGE(2608000, 3,  28, 16000),
>  		REGULATOR_LINEAR_RANGE(3104000, 29, 30, 96000),
>  		REGULATOR_LINEAR_RANGE(3312000, 31, 31, 0),
> -- 
> 2.43.0
> 
>