lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 14 Feb 2024 12:19:01 -0300
From: Rodrigo Campos <rodrigo@...g.com.ar>
To: Willy Tarreau <w@....eu>
Cc: Thomas Weißschuh <linux@...ssschuh.net>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] tools/nolibc: Fix strlcat() return code and size
 usage

On 2/13/24 08:02, Willy Tarreau wrote:
> Hi Rodrigo,
> 
> On Tue, Feb 13, 2024 at 12:16:06AM +0100, Rodrigo Campos wrote:
>> On 2/11/24 11:48, Willy Tarreau wrote:
>>> Hi Rodrigo,
> I've read it as well and I don't interpret it the same way. I'm reading it
> as "if dst doesn't contain a NUL char before size, its length is considered
> to be size", and the reason is explicitly explained just after:

Very true, I mixed dst and source. Thanks!

>> How are you measuring it there?
>>
>> Sorry, I'm not familiar with this :)
> 
> Oh, sorry for not providing the detalis! I just remove "static" in front
> of the function. 

Thanks for the examples and heuristics to keep code small :)

>> I've been playing, but as I can't measure the size, I'm not sure what is
>> really better. I'd like to play a little once I know how to measure it :)
> 
> Be careful not to spend too much time on it, nm --size and objdump are
> quickly addictive ;-)

Haha, it is definitely addictive.


I'll share some new versions in a minute.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ