[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdU8iJhXWFTrVqr8W-ov2D=oSUbsyDP1kfs6mC3rBcLxzQ@mail.gmail.com>
Date: Wed, 14 Feb 2024 16:26:52 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: claudiu beznea <claudiu.beznea@...on.dev>
Cc: wim@...ux-watchdog.org, linux@...ck-us.net, robh@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
p.zabel@...gutronix.de, geert+renesas@...der.be, magnus.damm@...il.com,
biju.das.jz@...renesas.com, linux-watchdog@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-renesas-soc@...r.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v6 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM
Hi Claudiu,
On Fri, Feb 9, 2024 at 1:25 PM claudiu beznea <claudiu.beznea@...ondev> wrote:
> On 08.02.2024 14:53, Geert Uytterhoeven wrote:
> > On Thu, Feb 8, 2024 at 1:26 PM Claudiu <claudiu.beznea@...on.dev> wrote:
> >> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> >>
> >> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
> >> clocks are enabled though pm_runtime_* specific APIs). To avoid building
> >> a driver that doesn't work make explicit the dependency on CONFIG_PM.
> >>
> >> Suggested-by: Guenter Roeck <linux@...ck-us.net>
> >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> >> ---
> >>
> >> Changes in v6:
> >> - update patch description
> >> - fixed the dependency on COMPILE_TEST previously introduced
> >
> > Thanks for the update!
> >
> >> --- a/drivers/watchdog/Kconfig
> >> +++ b/drivers/watchdog/Kconfig
> >> @@ -911,6 +911,7 @@ config RENESAS_RZN1WDT
> >> config RENESAS_RZG2LWDT
> >> tristate "Renesas RZ/G2L WDT Watchdog"
> >> depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
> >> + depends on PM
> >
> > depends on PM || COMPILE_TEST
>
> Isn't "depends on PM" enough? As of [1] ("If multiple dependencies are
> defined, they are connected with '&&'") the above:
>
> depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
> depends on PM
>
> are translated into:
> depends on (ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST) && PM
>
> Please let me know if I'm wrong.
That is correct. But you still can compile-test this driver when
compiling for a different platform, and CONFIG_PM is disabled.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists