linux-kernel - Re: [REGRESSION] `lis3lv02d_i2c_suspend()` causes `unbalanced disables for regulator-dummy` and `Failed to disable Vdd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 14 Feb 2024 16:34:29 +0100
From: "Linux regression tracking (Thorsten Leemhuis)"
 <regressions@...mhuis.info>
To: Mark Brown <broonie@...nel.org>, Paul Menzel <pmenzel@...gen.mpg.de>
Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Pali Rohár <pali@...nel.org>,
 Andi Shyti <andi.shyti@...nel.org>, linux-i2c@...r.kernel.org,
 Liam Girdwood <lgirdwood@...il.com>, LKML <linux-kernel@...r.kernel.org>,
 Hans de Goede <hdegoede@...hat.com>, regressions@...ts.linux.dev
Subject: Re: [REGRESSION] `lis3lv02d_i2c_suspend()` causes `unbalanced
 disables for regulator-dummy` and `Failed to disable Vdd_IO: -EIO`

On 08.02.24 15:34, Mark Brown wrote:
> On Fri, Feb 02, 2024 at 12:38:04PM +0100, Paul Menzel wrote:
> 
>> Testing commit 2f189493ae32 (i2c: i801: Add lis3lv02d for Dell XPS 15 7590)
>> [1], it’s very likely this commit, it turns out, that Linux logs the warning
>> below during ACPI S3 suspend:

Mark, many thx for your reply:

> The driver is just buggy here AFAICT,

/me reads that as "buggy even before 2f189493ae32, that commit just
exposed the problem"

> it's powering off the device in
> both runtime suspend and runtime resume so if the device is runtime
> suspended when system suspend happens then it'll power off the device
> again.  The runtime suspend and system suspend need to talk to each
> other here.

Well, that was 6 days ago and nothing further happened. Makes me wonder:
Who will look into this? And when? If not any time soon I guess we
sooner or later should consider revert this. Yes, the problem is "just"
a warning, but well, it's not "just" a warning for people using
panic_on_warn...

Paul, just to be sure: I assume reverting 2f189493ae32 fixes the problem?

Ciao, Thorsten