linux-kernel - Re: [PATCH 4/4] selftests/nolibc: Add tests for strlcat() and strlcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b469fca-e1bd-4c7b-9311-cf4d2270f8cd@sdfg.com.ar>
Date: Wed, 14 Feb 2024 12:52:10 -0300
From: Rodrigo Campos <rodrigo@...g.com.ar>
To: Willy Tarreau <w@....eu>, Thomas Weißschuh
 <linux@...ssschuh.net>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] selftests/nolibc: Add tests for strlcat() and
 strlcpy()

On 1/29/24 15:15, Rodrigo Campos wrote:
> +		/* For functions that take a long buffer, like strlcat() */
> +		char buf[7] = "foo";
> +

I've improved this to not be the same length as the other buffer (we 
can't catch mistakes like confusing the src and dst buffers like that) 
and added some trailing chars, so we also test that the \0 is added at 
the exactly right position.