linux-kernel - Re: [PATCH] dt-bindings: mfd: dlg,da9063: Make #interrupt-cells required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240214-divorcee-backside-3a3767d054e9@spud>
Date: Wed, 14 Feb 2024 15:58:27 +0000
From: Conor Dooley <conor@...nel.org>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Support Opensource <support.opensource@...semi.com>,
	Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Steve Twiss <stwiss.opensource@...semi.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mfd: dlg,da9063: Make #interrupt-cells
 required

Hey,

On Wed, Feb 14, 2024 at 04:03:42PM +0100, Geert Uytterhoeven wrote:
> '#interrupt-cells' is a required property for interrupt providers, hence
> make it required.

I actually meant to send this patch yesterday but I forgot, thanks for
doing it - the only riscv violation of what Rob reported was also a
da9063..

> While at it, move '#interrupt-cells' in the example to match common sort
> order.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

I think:
Fixes: 361104b05684 ("dt-bindings: mfd: Convert da9063 to yaml")

and
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Cheers,
Conor.

> ---
>  Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> index c5a7e10d7d80e8d7..e5ccc2708f0bb0f8 100644
> --- a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> +++ b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> @@ -87,6 +87,7 @@ required:
>    - reg
>    - interrupts
>    - interrupt-controller
> +  - '#interrupt-cells'
>  
>  additionalProperties: false
>  
> @@ -99,10 +100,10 @@ examples:
>        pmic@58 {
>          compatible = "dlg,da9063";
>          reg = <0x58>;
> -        #interrupt-cells = <2>;
>          interrupt-parent = <&gpio6>;
>          interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
>          interrupt-controller;
> +        #interrupt-cells = <2>;
>  
>          rtc {
>            compatible = "dlg,da9063-rtc";
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)