linux-kernel - Re: [PATCH v2] of: OF_IRQ: select IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8634tv57i2.wl-maz@kernel.org>
Date: Wed, 14 Feb 2024 16:35:17 +0000
From: Marc Zyngier <maz@...nel.org>
To: "Arnd Bergmann" <arnd@...db.de>
Cc: "Randy Dunlap" <rdunlap@...radead.org>,
	linux-kernel@...r.kernel.org,
	"Geert Uytterhoeven" <geert@...ux-m68k.org>,
	"Rob Herring" <robh@...nel.org>,
	"Philipp Zabel" <p.zabel@...gutronix.de>,
	"Peter Rosin" <peda@...ntia.se>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v2] of: OF_IRQ: select IRQ_DOMAIN instead of depending on it

On Wed, 14 Feb 2024 16:06:06 +0000,
"Arnd Bergmann" <arnd@...db.de> wrote:
> 
> On Wed, Feb 14, 2024, at 10:52, Marc Zyngier wrote:
> > On Tue, 13 Feb 2024 22:56:19 +0000, Randy Dunlap <rdunlap@...radead.org> wrote:
> >>
> >> diff -- a/drivers/of/Kconfig b/drivers/of/Kconfig
> >> --- a/drivers/of/Kconfig
> >> +++ b/drivers/of/Kconfig
> >> @@ -80,7 +80,8 @@ config OF_ADDRESS
> >>  
> >>  config OF_IRQ
> >>  	def_bool y
> >> -	depends on !SPARC && IRQ_DOMAIN
> >> +	depends on !SPARC
> >> +	select IRQ_DOMAIN
> > 
> >
> > This seems to be moving is the right direction.
> 
> Can we move the 'select IRQ_DOMAIN' under CONFIG_IRQCHIP
> then and remove the individual selects from the irqchip
> drivers? It looks like CONFIG_OF (other than sparc) now
> unconditionally enables OF_IRQ and IRQCHIP anyway.

As long as it also works ACPI, it should be OK.

	M.

-- 
Without deviation from the norm, progress is not possible.