linux-kernel - Re: [PATCH net] pppoe: Fix memory leak in pppoe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 16:00:30 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Gavrilov Ilia <Ilia.Gavrilov@...otecs.ru>
Cc: mostrows@...thlink.net, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org,
 syzbot+6bdfd184eac7709e5cc9@...kaller.appspotmail.com
Subject: Re: [PATCH net] pppoe: Fix memory leak in pppoe_sendmsg()

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 14 Feb 2024 09:01:50 +0000 you wrote:
> syzbot reports a memory leak in pppoe_sendmsg [1].
> 
> The problem is in the pppoe_recvmsg() function that handles errors
> in the wrong order. For the skb_recv_datagram() function, check
> the pointer to skb for NULL first, and then check the 'error' variable,
> because the skb_recv_datagram() function can set 'error'
> to -EAGAIN in a loop but return a correct pointer to socket buffer
> after a number of attempts, though 'error' remains set to -EAGAIN.
> 
> [...]

Here is the summary with links:
  - [net] pppoe: Fix memory leak in pppoe_sendmsg()
    https://git.kernel.org/netdev/net/c/dc34ebd5c018

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html