linux-kernel - Re: [PATCH net v3] net: ravb: Count packets instead of descriptors in GbEth RX path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 16:10:27 +0000
From: Paul Barker <paul.barker.ct@...renesas.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Sergey Shtylyov <s.shtylyov@....ru>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Nikita Yushchenko <nikita.yoush@...entembedded.com>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Claudiu Beznea <claudiu.beznea.uj@...renesas.com>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
 Biju Das <biju.das.jz@...renesas.com>, netdev@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v3] net: ravb: Count packets instead of descriptors in
 GbEth RX path

On 15/02/2024 16:03, Jakub Kicinski wrote:
> On Wed, 14 Feb 2024 15:12:04 +0000 Paul Barker wrote:
>> The units of "work done" in the RX path should be packets instead of
>> descriptors, as large packets can be spread over multiple descriptors.
> 
> FWIW one of y'all may also want to look into processing Tx completions
> before Rx. Tx completions can free memory which Rx can then consume.
> More efficient. Not to mention netconsole being able to reap Tx with
> budget of 0.

Thanks for the recommendation - I'll make this change as part of v3 of
the series "Improve GbEth performance on Renesas RZ/G2L and related
SoCs" [1] once we've completed gPTP testing.

[1]: https://lore.kernel.org/netdev/20240206091909.3191-1-paul.barker.ct@bp.renesas.com/

-- 
Paul Barker
Download attachment "OpenPGP_0x27F4B3459F002257.asc" of type "application/pgp-keys" (3521 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)