linux-kernel - Re: [PATCH] minmax: substitute local variables using __UNIQUE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zc4-mgji8VtQDqGe@smile.fi.intel.com>
Date: Thu, 15 Feb 2024 18:40:58 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Yueh-Shun Li <shamrocklee@...teo.net>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Mark Brown <broonie@...nel.org>,
	Herve Codina <herve.codina@...tlin.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] minmax: substitute local variables using __UNIQUE_ID()

On Thu, Feb 15, 2024 at 04:07:21PM +0000, Yueh-Shun Li wrote:
> Substitute identifier names of local variables used in macro
> definitions inside minmax.h with those generated by __UNIQUE_ID(prefix)
> to eliminate passible naming collisions.
> 
> Identifier names like __x, __y and __tmp are everywhere inside the
> kernel source. This patch ensures that macros provided by minmax.h
> will work even when identifiers of these names appear in the expanded
> input arguments.

..

> +#define min_not_zero(x, y) \
> +	__min_not_zero_impl(x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y))
> +#define __min_not_zero_impl(x, y, __x, __y)                          \

Seems like the back slashes are indented at random.

Please, use TABs and make sure in a macro / group of (semantically related)
macros they are consistently occupy _the same_ column.

-- 
With Best Regards,
Andy Shevchenko