linux-kernel - RE: [PATCH 1/1] Documentation: hyperv: Add overview of PCI pass-thru device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 19:04:17 +0000
From: Michael Kelley <mhklinux@...look.com>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>, "haiyangz@...rosoft.com"
	<haiyangz@...rosoft.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>,
	"decui@...rosoft.com" <decui@...rosoft.com>, "corbet@....net"
	<corbet@....net>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>
Subject: RE: [PATCH 1/1] Documentation: hyperv: Add overview of PCI pass-thru
 device support

From: Easwar Hariharan <eahariha@...ux.microsoft.com> Sent: Thursday, February 15, 2024 10:41 AM
> 
> On 2/14/2024 3:22 PM, mhkelley58@...il.com wrote:
> >
> > Add documentation topic for PCI pass-thru devices in Linux guests
> > on Hyper-V and for the associated PCI controller driver (pci-hyperv.c).
> >
> > Signed-off-by: Michael Kelley <mhklinux@...look.com>
> > ---

[snip]

> > +
> > +With this approach, the vPCI device is a VMBus device and a
> > +PCI device at the same time.  In response to the VMBus offer
> > +message, the hv_pci_probe() function runs and establishes a
> > +VMBus connection to the vPCI VSP on the Hyper-V host.  That
> > +connection has a single VMBus channel.  The channel is used to
> > +exchange messages with the vPCI VSP for the purpose of setting
> > +up and configuring the vPCI device in Linux.  Once the device
> > +is fully configured in Linux as a PCI device, the VMBus
> > +channel is used only if Linux changes the vCPU to be
> > +interrupted in the guest, or
> 
> 
> > ..............................if the vPCI device is removed by
> > +the VM while the VM is running.
> 
> This seems to conflict with the statement called out below. Did you
> mean to say "if the vPCI device is removed *from* the VM..."?
> 

Oops!  Yes, that should be "from the VM".

[snip]

> 
> Otherwise, FWIW
> 
> Reviewed-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
> 

Thanks for reviewing and spotting that error.  I'll see what
other comments accumulate and then send out a v2 with
updates.

Michael