linux-kernel - RE: [PATCH] hexagon: select FRAME_POINTER instead of redefining it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 19:12:38 +0000
From: Brian Cain <bcain@...cinc.com>
To: Masahiro Yamada <masahiroy@...nel.org>,
        "linux-kbuild@...r.kernel.org"
	<linux-kbuild@...r.kernel.org>
CC: "linux-hexagon@...r.kernel.org" <linux-hexagon@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] hexagon: select FRAME_POINTER instead of redefining it



> -----Original Message-----
> From: Masahiro Yamada <masahiroy@...nel.org>
> Sent: Thursday, February 15, 2024 8:07 AM
> To: linux-kbuild@...r.kernel.org
> Cc: Masahiro Yamada <masahiroy@...nel.org>; Brian Cain
> <bcain@...cinc.com>; linux-hexagon@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] hexagon: select FRAME_POINTER instead of redefining it
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
> 
> Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
> should select it.
> 
> Add 'select FRAME_POINTER' to HEXAGON. ARCH_WANT_FRAME_POINTERS
> must
> also be selected to avoid the unmet dependency warning.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  arch/hexagon/Kconfig | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> index a880ee067d2e..e922026fef09 100644
> --- a/arch/hexagon/Kconfig
> +++ b/arch/hexagon/Kconfig
> @@ -7,7 +7,9 @@ config HEXAGON
>         select ARCH_32BIT_OFF_T
>         select ARCH_HAS_SYNC_DMA_FOR_DEVICE
>         select ARCH_NO_PREEMPT
> +       select ARCH_WANT_FRAME_POINTERS
>         select DMA_GLOBAL_POOL
> +       select FRAME_POINTER
>         # Other pending projects/to-do items.
>         # select HAVE_REGS_AND_STACK_ACCESS_API
>         # select HAVE_HW_BREAKPOINT if PERF_EVENTS
> @@ -43,9 +45,6 @@ config HEXAGON_PHYS_OFFSET
>         help
>           Platforms that don't load the kernel at zero set this.
> 
> -config FRAME_POINTER
> -       def_bool y
> -
>  config LOCKDEP_SUPPORT
>         def_bool y
> 
> --
> 2.40.1


Acked-by: Brian Cain <bcain@...cinc.com>