linux-kernel - Re: [PATCH v1 06/14] linux/mm.h: move page_size() to mm/page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 20:35:58 +0100
From: Max Kellermann <max.kellermann@...os.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 06/14] linux/mm.h: move page_size() to mm/page_size.h

On Thu, Feb 15, 2024 at 8:26 PM Matthew Wilcox <willy@...radead.org> wrote:
> We're really close to eliminating page_size().  Just 23 callers left.
> As such, it would be a mistake to name the header after it.  I don't
> particularly like how you're splitting up mm.h; I think the real problem
> is all the code that says "Oh, I'm allocating memory, I should include
> mm.h" instead of including gfp.h or slab.h.

Yes, a lot of source files do that, but that mistake is not something
I'm addressing in this patch series; another patch series I posted two
weeks ago is about that.
This series is only about making sources lighter which currently
indeed need mm.h.

> But if you must split it like this, at least call it folio_size.h

Okay, I will rename it for v2.