linux-kernel - Re: [PATCH] scsi: ufs: uninitialized variable in ufshcd_devfreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 05:53:40 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "dan.carpenter@...aro.org" <dan.carpenter@...aro.org>
CC: "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"quic_nguyenb@...cinc.com" <quic_nguyenb@...cinc.com>, "jejb@...ux.ibm.com"
	<jejb@...ux.ibm.com>, "quic_ziqichen@...cinc.com"
	<quic_ziqichen@...cinc.com>, "beanhuo@...ron.com" <beanhuo@...ron.com>,
	"avri.altman@....com" <avri.altman@....com>, "bvanassche@....org"
	<bvanassche@....org>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>,
	Stanley Chu (朱原陞) <stanley.chu@...iatek.com>,
	"athierry@...hat.com" <athierry@...hat.com>, "quic_cang@...cinc.com"
	<quic_cang@...cinc.com>
Subject: Re: [PATCH] scsi: ufs: uninitialized variable in
 ufshcd_devfreq_target()

On Tue, 2024-02-13 at 21:08 +0300, Dan Carpenter wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  There is one goto where "sched_clk_scaling_suspend_work" is true but
> "scale_up" is uninitialized.  It leads to a Smatch uninitialized
> variable
> warning:
> 
> drivers/ufs/core/ufshcd.c:1589 ufshcd_devfreq_target() error:
> uninitialized symbol 'scale_up'.
> 
> Fixes: 1d969731b87f ("scsi: ufs: core: Only suspend clock scaling if
> scaling down")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> 

Reviewed-by: Peter Wang <peter.wang@...iatek.com>